Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes needed for HLT TDR event content : 11_2 #30899

Merged
merged 1 commit into from Jul 27, 2020

Conversation

Sam-Harper
Copy link
Contributor

PR description:

This PR adds in changes needed for the HLT event content. Suggestions on how to achieve this are welcome if the way I've done it is incorrect

At the same time it adds customisePhase2TTOn110 which reinstates the track trigger tracking particle associators which are useful and should be kept.

Finally the content is still being checked but should be reasonably close to final.

PR validation:

On testing with

cmsDriver.py step2 --conditions 111X_mcRun4_realistic_T15_v1 -n 10 --era Phase2C9 --eventcontent RECOSIM --runUnscheduled -s RAW2DIGI,L1TrackTrigger,L1,RECO,RECOSIM,PAT --datatier FEVT --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000,L1Trigger/Configuration/customisePhase2TTOn110.customisePhase2TTOn110 --geometry Extended2026D49 --customise_command "process.RECOSIMoutput.outputCommands.append('keep *_*_*_HLT') \n process.RECOSIMoutput.outputCommands.append('keep *_*_*_SIM') \n process.RECOSIMoutput.outputCommands.extend(process.L1TriggerFEVTDEBUG.outputCommands) \n process.RECOSIMoutput.outputCommands.extend(process.MicroEventContentMC.outputCommands) \n process.load('HLTrigger.Configuration.HLTPhase2TDR_EventContent_cff') \n process.RECOSIMoutput.outputCommands.extend(process.HLTPhase2TDR.outputCommands) \n " --mc --io HLTTDR2026D49ProdOneGo_Test.io --python HLTTDR2026D49ProdOneGo_Test.py --nStreams 4 --no_exec --filein file:/data1/harper/mcFiles/TT_TuneCP5_14TeV-powheg-pythia8__Phase2HLTTDRWinter20DIGI__PU200_110X_mcRun4_realistic_v3-v2__GEN-SIM-DIGI-RAW__5F12BF73-60EA-A74E-AD2E-36F78AE70B96.root --fileout file:test_cmsDriverCMD.root --nThreads 8

the expected event content was produced

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30899/17294

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

HLTrigger/Configuration
L1Trigger/Configuration

@cmsbuild, @rekovic, @benkrikler, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

urgent

@cmsbuild
Copy link
Contributor

+1
Tested at: f776625
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfbe4/8279/summary.html
CMSSW: CMSSW_11_2_X_2020-07-24-1400
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dfbe4/8279/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2526188
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2526140
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

@rekovic @Martin-Grunewald can we merge this PR?

@Martin-Grunewald
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ba425d6 into cms-sw:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants