Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change iev default so that by default no file is read. #3096

Merged
merged 1 commit into from Apr 1, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Mar 29, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Change iev default so that by default no file is read.

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 1, 2014

+1

for dfd9777
based on jenkins and check of code changes, not affecting any active wflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 1, 2014
RecoJets/JetProducers -- Change iev default so that by default no file is read.
@nclopezo nclopezo merged commit 7149f8a into cms-sw:CMSSW_7_1_X Apr 1, 2014
@ktf
Copy link
Contributor Author

ktf commented Apr 1, 2014

@smuzaffar do you understand why the test works in the IB, but blocks waiting for input while running in a developer area via scram b runtests?

@smuzaffar
Copy link
Contributor

In IB env STDIN is closed. If you run scram build runtests </dev/null then it will not wait for input

@ktf
Copy link
Contributor Author

ktf commented Apr 1, 2014

Ok, then my fix should be an equivalent default. Thanks.

@ktf ktf deleted the fix-voronoi branch January 28, 2015 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants