Clean up L1TTrackMatch producers #30970
Conversation
|
The code-checks are being triggered in jenkins. |
| using namespace edm; | ||
|
|
||
| std::unique_ptr<TkPrimaryVertexCollection> result(new TkPrimaryVertexCollection); | ||
| auto result = std::make_unique<TkPrimaryVertexCollection>(); | ||
|
|
||
| // Tracker Topology | ||
| edm::ESHandle<TrackerTopology> tTopoHandle_; | ||
| iSetup.get<TrackerTopologyRcd>().get(tTopoHandle_); |
There was a problem hiding this comment.
Could we also get esConsumes used with the appropriate token?
There was a problem hiding this comment.
Sure, I'll do that now.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30970/17406
|
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: L1Trigger/L1TTrackMatch @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30970/17407
|
|
Pull request #30970 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
@rekovic please take a look |
|
merge |
PR description:
@Dr15Jones pointed out that the producers introduced in #30363 were not converted from legacy producers to modern producers. I converted them and applied the usual code review comments that were skipped/ignored in the original PR:
PR validation:
Ran workflow 23234.0 successfully.
Should this be backported to 11_1_X?