New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize modules in CalibTracker/SiStripCommon #31002
Modernize modules in CalibTracker/SiStripCommon #31002
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/17460
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
f4ec46c
to
4cad49b
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/17463
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiStripCommon @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 4cad49b CMSSW: CMSSW_11_2_X_2020-07-30-2300 I found follow errors while testing this PR Failed tests: HeaderConsistency |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/18533
|
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@pohsun, @christopheralanwest @tlampen, @yuanchao just in case you've missed it, this PR is open for review since 6 days. Thank you. |
+alca thanks for reminding. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@@ -4,6 +4,7 @@ | |||
<use name="DataFormats/SiStripDetId"/> | |||
<use name="DataFormats/Scalers"/> | |||
<use name="DataFormats/OnlineMetaData"/> | |||
<use name="SimDataFormats/TrackingAnalysis"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you move SimDataFormats/TrackingAnalysis
from CalibTracker/SiStripCommon/plugins/BuildFile.xml
to CalibTracker/SiStripCommon/BuildFile.xml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silviodonato in an earlier iteration before rebasing I had moved some headers to the interface
directory, and that required this change. For the final version I dropped that change, so shall I put SimDataFormats/TrackingAnalysis
back to where it was?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already seen a similar discussion in a @guitargeek's PR #31533 (comment)
Rule 6.6 of https://cms-sw.github.io/cms_coding_rules.html suggests to have a dedicated BuildFile.xml
for plugins.
I think this prevents to have cyclic dependencies, but I'm not 100% sure.
shall I put SimDataFormats/TrackingAnalysis back to where it was?
it is not urgent, but you can include it in your next PR
+1 |
PR description:
Title says it all, part of #25090.
Profited to clean-up some commented code too.
PR validation:
Code compiles + run
runTheMatrix.py -l 1001.0 -t 4
.Also exercised the unit tests of
CalibTracker/SiStripCommon
andCalibTracker/SiStripChannelGain
.if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport.