Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize modules in CalibTracker/SiStripCommon #31002

Merged
merged 1 commit into from Sep 28, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 31, 2020

PR description:

Title says it all, part of #25090.
Profited to clean-up some commented code too.

PR validation:

Code compiles + run runTheMatrix.py -l 1001.0 -t 4.
Also exercised the unit tests of CalibTracker/SiStripCommon and CalibTracker/SiStripChannelGain.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 31, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/17460

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/17463

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripCommon

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mverzett, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 31, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 4cad49b

CMSSW: CMSSW_11_2_X_2020-07-30-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9d5b8/8459/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31002/18533

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31002 was updated. @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 22, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: d1eb31b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9d5b8/9493/summary.html
CMSSW: CMSSW_11_2_X_2020-09-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9d5b8/9493/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2540471
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2540442
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Sep 28, 2020

@pohsun, @christopheralanwest @tlampen, @yuanchao

just in case you've missed it, this PR is open for review since 6 days. Thank you.

@tlampen
Copy link
Contributor

tlampen commented Sep 28, 2020

+alca

thanks for reminding.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@@ -4,6 +4,7 @@
<use name="DataFormats/SiStripDetId"/>
<use name="DataFormats/Scalers"/>
<use name="DataFormats/OnlineMetaData"/>
<use name="SimDataFormats/TrackingAnalysis"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you move SimDataFormats/TrackingAnalysis from CalibTracker/SiStripCommon/plugins/BuildFile.xml to CalibTracker/SiStripCommon/BuildFile.xml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviodonato in an earlier iteration before rebasing I had moved some headers to the interface directory, and that required this change. For the final version I dropped that change, so shall I put SimDataFormats/TrackingAnalysis back to where it was?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already seen a similar discussion in a @guitargeek's PR #31533 (comment)

Rule 6.6 of https://cms-sw.github.io/cms_coding_rules.html suggests to have a dedicated BuildFile.xml for plugins.
I think this prevents to have cyclic dependencies, but I'm not 100% sure.

shall I put SimDataFormats/TrackingAnalysis back to where it was?

it is not urgent, but you can include it in your next PR

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants