Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize modules in HeavyFlavorAnalysis/Onia2MuMu #31026

Merged
merged 3 commits into from Aug 7, 2020
Merged

Modernize modules in HeavyFlavorAnalysis/Onia2MuMu #31026

merged 3 commits into from Aug 7, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Converted legacy modules to thread efficient versions. In addition did some minor improvements.

This is assiciated with #25090.

PR validation:

The code compiles.

@Dr15Jones
Removed use of EventSetup from OniaVtxReProducer
e821f6a 
The needed TransientTrackBuilder is now directly passed to the
function.
@Dr15Jones
Made OniaAddV0TracksProducer a global module
2919017 
Also fixed two memory leaks
@Dr15Jones
Modernized Onia2MuMuPAT
a68e7a4 
- converted to a stream module
- added a fillDescriptions
- use ESGetTokens
@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Aug 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31026/17516

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

HeavyFlavorAnalysis/Onia2MuMu

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

+1
Tested at: a68e7a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54638f/8514/summary.html
CMSSW: CMSSW_11_2_X_2020-08-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54638f/8514/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525448
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525394
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@santocch
Copy link

santocch commented Aug 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 56afd90 into cms-sw:master Aug 7, 2020
@cmsbuild cmsbuild mentioned this pull request Aug 7, 2020
Merged
@Dr15Jones Dr15Jones deleted the modernizeHeavyFlavorAnalysisOnia2MuMu branch August 28, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @santocch @silviodonato