Update of the DT migration to DD4HEP #31043

slomeo · 2020-08-04T09:32:34Z

PR description:

Update the DT migration to DD4hep after @bsunanda PRs #29842 #29943 and @ianna PR #29954.

PR validation:

validation made by Geometry/DTGeometryBuilder/test/python/validateDTGeometry_cfg.py
validation by runTheMatrix.py -l 25202.1 :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Aug 4 11:08:53 2020-date Tue Aug 4 10:46:39 2020; exit: 0 0 0 0 1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

cmsbuild · 2020-08-04T09:32:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-04T09:39:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31043/17542

This PR adds an extra 28KB to repository

cmsbuild · 2020-08-04T09:39:48Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/DTGeometryBuilder
Geometry/MuonNumbering

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ptcox, @fabiocos, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-08-04T12:02:57Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-04T12:07:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31043/17545

This PR adds an extra 28KB to repository

cmsbuild · 2020-08-04T12:08:15Z

Pull request #31043 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

cvuosalo · 2020-08-04T15:44:21Z

Geometry/MuonNumbering/src/DTNumberingScheme.cc

@@ -32,7 +42,8 @@ int DTNumberingScheme::baseNumberToUnitNumber(const MuonBaseNumber& num) const {
    edm::LogVerbatim("DTNumberingScheme") << level << " " << num.getSuperNo(level) << " " << num.getBaseNo(level);
  }
 #endif
-  if (num.getLevels() != theWireLevel) {
+  //  if (num.getLevels() != theWireLevel) {
+  if (num.getLevels() < theStationLevel) {


Are you sure you want to keep this version of the if statement? What is the correct number of levels? Have you talked to Sunanda about this? He recently fixed a similar problem with the GEMs.
Whatever you decide, make sure the message on line 48 matches the if.

@cvuosalo I didn't talk with @bsunanda

He recently fixed a similar problem with the GEMs.

@bsunanda how did you fix it for GEMs?

@cvuosalo I fixed line 48

@cvuosalo probably it could be better to go forward with this PR in order to test it (i.e "please test") in order to see if all is fine, then I will get in touch (offline) with @bsunanda and you in order to understand better the number levels issue

@slomeo I just give a warning sign and proceed. I test the number of levels at each step before assigning chamber, roll, ...

cmsbuild · 2020-08-04T16:37:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-04T16:41:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31043/17554

This PR adds an extra 28KB to repository

cmsbuild · 2020-08-04T16:41:45Z

Pull request #31043 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

cvuosalo · 2020-08-04T22:14:33Z

Geometry/MuonNumbering/src/DTNumberingScheme.cc

    edm::LogWarning("DTNumberingScheme") << "DTNumberingScheme::BNToUN: BaseNumber has " << num.getLevels()
-                                         << " levels, need " << theWireLevel;
+                                         << " levels, need " << theWireLevel;  //it was theWireLevel;


Suggested change

<< " levels, need " << theWireLevel; //it was theWireLevel;

<< " levels, need " << theStationLevel; //it was theWireLevel;

@cvuosalo : done

cvuosalo · 2020-08-04T22:15:08Z

@cmsbuild please test

cmsbuild · 2020-08-04T22:15:32Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-04-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8569/console Started: 2020/08/05 00:17

cmsbuild · 2020-08-31T11:56:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-31T12:02:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31043/18029

This PR adds an extra 20KB to repository

cmsbuild · 2020-08-31T12:03:01Z

Pull request #31043 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

slomeo · 2020-08-31T12:03:15Z

@cmsbuild please test

cmsbuild · 2020-08-31T12:03:40Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 25202.1
CMSSW_11_2_X_2020-08-31-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9015/console Started: 2020/08/31 14:04

cmsbuild · 2020-08-31T13:23:03Z

+1
Tested at: 94fbdcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42353/9015/summary.html
CMSSW: CMSSW_11_2_X_2020-08-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-31T13:23:05Z

Comparison job queued.

cmsbuild · 2020-08-31T14:50:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42353/9015/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c42353/25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2609639
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-08-31T20:34:37Z

+1

cmsbuild · 2020-08-31T20:35:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-01T01:53:08Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Aug 4, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Aug 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2020

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2020

cvuosalo reviewed Aug 4, 2020

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2020

cvuosalo reviewed Aug 4, 2020

View reviewed changes

cmsbuild added code-checks-pending comparison-pending tests-pending labels Aug 31, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 31, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 31, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 31, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 31, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Aug 31, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 1, 2020

cmsbuild merged commit cfcbf3c into cms-sw:master Sep 1, 2020

slomeo mentioned this pull request Jul 27, 2021

[DD4hep] DT geometry builder unit test does not fail when it should #29206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of the DT migration to DD4HEP #31043

Update of the DT migration to DD4HEP #31043

slomeo commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cvuosalo Aug 4, 2020

slomeo Aug 4, 2020 •

edited

slomeo Aug 4, 2020

slomeo Aug 4, 2020

bsunanda Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cvuosalo Aug 4, 2020

slomeo Aug 5, 2020

cvuosalo commented Aug 4, 2020

cmsbuild commented Aug 4, 2020 •

edited

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

slomeo commented Aug 31, 2020

cmsbuild commented Aug 31, 2020 •

edited

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cvuosalo commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

qliphy commented Sep 1, 2020

	<< " levels, need " << theWireLevel; //it was theWireLevel;
	<< " levels, need " << theStationLevel; //it was theWireLevel;

Update of the DT migration to DD4HEP #31043

Update of the DT migration to DD4HEP #31043

Conversation

slomeo commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cvuosalo Aug 4, 2020

Choose a reason for hiding this comment

slomeo Aug 4, 2020 • edited

Choose a reason for hiding this comment

slomeo Aug 4, 2020

Choose a reason for hiding this comment

slomeo Aug 4, 2020

Choose a reason for hiding this comment

bsunanda Aug 4, 2020

Choose a reason for hiding this comment

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

cvuosalo Aug 4, 2020

Choose a reason for hiding this comment

slomeo Aug 5, 2020

Choose a reason for hiding this comment

cvuosalo commented Aug 4, 2020

cmsbuild commented Aug 4, 2020 • edited

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

slomeo commented Aug 31, 2020

cmsbuild commented Aug 31, 2020 • edited

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

cvuosalo commented Aug 31, 2020

cmsbuild commented Aug 31, 2020

qliphy commented Sep 1, 2020

slomeo Aug 4, 2020 •

edited

cmsbuild commented Aug 4, 2020 •

edited

cmsbuild commented Aug 31, 2020 •

edited