Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove L1Tk paths defined in L1TkObjectProducers_cff.py #31057

Merged
merged 3 commits into from Aug 7, 2020

Conversation

silviodonato
Copy link
Contributor

PR description:

As commented in #31054, the L1Tk paths defined in L1TkObjectProducers_cff.py are not necessary and make confusion. This PR deletes L1TkObjectProducers_cff including those L1Tk paths, and add the minimal configuration needed into SimL1Emulator_cff.py

PR validation:

runTheMatrix.py -l 23234.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

no backport, so far

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17569

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TTrackMatch

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The tests are being triggered in jenkins.

Copy link
Contributor

@srimanob srimanob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you delete L1TkObjectProducers_cff.py but why it is still mentioned in SimL1Emulator.

from L1Trigger.L1TTrackMatch.L1TkObjectProducers_cff import *

@silviodonato
Copy link
Contributor Author

abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17573

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17575

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Pull request #31057 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+1
Tested at: d4fa06f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1d68/8584/summary.html
CMSSW: CMSSW_11_2_X_2020-08-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc1d68/8584/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2612401
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2612347
  • DQMHistoTests: Total skipped: 48
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 5, 2020

+upgrade

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 44a2c23 into cms-sw:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants