New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove L1Tk paths defined in L1TkObjectProducers_cff.py #31057
Remove L1Tk paths defined in L1TkObjectProducers_cff.py #31057
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17569
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you delete L1TkObjectProducers_cff.py but why it is still mentioned in SimL1Emulator.
from L1Trigger.L1TTrackMatch.L1TkObjectProducers_cff import * |
…mL1Emulator_cff.py
abort |
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17573
|
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31057/17575
|
The tests are being triggered in jenkins.
|
Pull request #31057 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
merge |
PR description:
As commented in #31054, the L1Tk paths defined in
L1TkObjectProducers_cff.py
are not necessary and make confusion. This PR deletesL1TkObjectProducers_cff
including those L1Tk paths, and add the minimal configuration needed intoSimL1Emulator_cff.py
PR validation:
runTheMatrix.py -l 23234.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
no backport, so far