New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCAL MC: adding pulse shape 208 for signal reconstruction (11_1_X) #31062
HCAL MC: adding pulse shape 208 for signal reconstruction (11_1_X) #31062
Conversation
A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_11_1_X. It involves the following packages: CalibCalorimetry/HcalAlgos @civanch, @christopheralanwest, @tocheng, @cmsbuild, @mdhildreth, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport #31014 |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backporting new HCAL MC reco pulse shape to 11_1, see #31014.
It is deactivated by default and can be activated by HcalRecoParams conditions.
PR validation:
Workflow 11634.0 runs with default and new pulse shape.