Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL MC: adding pulse shape 208 for signal reconstruction (11_1_X) #31062

Merged
merged 2 commits into from Aug 6, 2020

Conversation

mseidel42
Copy link
Contributor

PR description:

Backporting new HCAL MC reco pulse shape to 11_1, see #31014.
It is deactivated by default and can be activated by HcalRecoParams conditions.

PR validation:

Workflow 11634.0 runs with default and new pulse shape.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_11_1_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
SimCalorimetry/HcalSimAlgos

@civanch, @christopheralanwest, @tocheng, @cmsbuild, @mdhildreth, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mariadalfonso, @rovere, @abdoulline, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

backport #31014

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

+1
Tested at: 0bad4d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-113be9/8589/summary.html
CMSSW: CMSSW_11_1_X_2020-08-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-113be9/8589/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-113be9/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780740
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 6, 2020

+1

@tlampen
Copy link
Contributor

tlampen commented Aug 6, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b9ad557 into cms-sw:CMSSW_11_1_X Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants