Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert L1TkMuon to stream producer [11_1_X] #31099

Merged
merged 1 commit into from Oct 19, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Aug 7, 2020

backport of #31098

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/L1TTrackMatch

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2020

+1
Tested at: 6eb82aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c92e/8666/summary.html
CMSSW: CMSSW_11_1_X_2020-08-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c92e/8666/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a8c92e/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Aug 8, 2020

@slava77 did the matrix map changes get applied to 11_1_X? I think we want to keep the OldDigi test here

@kpedro88
Copy link
Contributor Author

+upgrade

@srimanob
Copy link
Contributor

Hi @kpedro88
As current production is ongoing without this PR, do you see any issue?

@kpedro88
Copy link
Contributor Author

If production jobs aren't encountering the issue #31097, then this PR doesn't need to be merged. We can leave it here in case the issue does arise.

@silviodonato
Copy link
Contributor

If production jobs aren't encountering the issue #31097, then this PR doesn't need to be merged. We can leave it here in case the issue does arise.

I'm converting this PR as a draft just to remove this from the ORP spreadsheet. Of course feel free to open it back if needed.

@silviodonato silviodonato marked this pull request as draft September 7, 2020 13:16
@silviodonato silviodonato marked this pull request as ready for review October 19, 2020 06:40
@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 6eb82aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c92e/10065/summary.html
CMSSW: CMSSW_11_1_X_2020-10-18-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8c92e/10065/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784776
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784725
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

unhold

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants