[DD4hep] Migrate to a new version of DD4hep

[ianna]

PR description:

• Use DD4hep Filter and SpecParRegistry, remove local copies.

@cvuosalo - this is a second step in cleaning up DetectorDescription/DDCMS

@mrodozov - this PR will help you to reproduce the missing symbols problem. It's done for DetectorDescription/DDCMS package only.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17806

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): Add DDExtrudedPolygon, DDPolycone, and DDPolyhedra shapes for reading shape parameters #30931
  • File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): [DD4hep] Extra Check on a DOM Document Validity #31003

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17806/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17806/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17816

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): Add DDExtrudedPolygon, DDPolycone, and DDPolyhedra shapes for reading shape parameters #30931
  • File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): [DD4hep] Extra Check on a DOM Document Validity #31003

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[ianna]

@mrodozov - now it should be fully functional when the dd4hep external library is fixed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17833

• This PR adds an extra 144KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): Add DDExtrudedPolygon, DDPolycone, and DDPolyhedra shapes for reading shape parameters #30931
  • File DetectorDescription/DDCMS/plugins/dd4hep/DDDefinitions2Objects.cc modified in PR(s): [DD4hep] Extra Check on a DOM Document Validity #31003
  • File Geometry/DTGeometryBuilder/plugins/dd4hep/DTGeometryBuilder.cc modified in PR(s): Update of the DT migration to DD4HEP #31043
  • File Geometry/DTGeometryBuilder/plugins/dd4hep/DTGeometryBuilder.h modified in PR(s): Update of the DT migration to DD4HEP #31043

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17833/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31173/17833/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+1
Tested at: f44dda1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7061af/8842/summary.html
CMSSW: CMSSW_11_2_X_2020-08-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7061af/8842/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2608222
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2608199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cvuosalo]

+1

[civanch]

+1

[ianna]

@kpedro88 - please, review. Thanks!

[ianna]

@kpedro88 - please, review this PR. Thanks!

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1