Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of mixObjects_cfi.py without PLTHits line comment #3119

Merged
merged 1 commit into from Apr 1, 2014

Conversation

skaplanhex
Copy link
Contributor

As requested by @ktf in my previous pull request (#3087), this pull request includes the changes I introduced to SimGeneral/MixingModule/python/mixObjects_cfi.py without the PLTHits comment line.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @skaplanhex (Steven Kaplan) for CMSSW_7_1_X.

Version of mixObjects_cfi.py without PLTHits line comment

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Mar 31, 2014

+1
comments for Crossing frame parameters are still there but it is better if Mike remove this and not Steven.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 1, 2014
Sim -- Version of mixObjects_cfi.py without PLTHits line comment
@ktf ktf merged commit aa957f0 into cms-sw:CMSSW_7_1_X Apr 1, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2014

@skaplanhex skaplanhex deleted the pltCommentFix branch April 1, 2014 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants