change return type of geomTracker to derived class (TrackerGeometry vs TrackingGeometry)

[davidlange6]

#31192 plus review changes (I messed up the rebase so started over..)

nominally this PR is to work around errors flagged by modules build. There is a mix of TrackerGeometry and TrackingGeometry (esp in Egamma) that I don't fully understand the logic of as there is presumably only one relevant derived type from TrackingGeometry (which is TrackerGeometry) for anything that is not a muon algorithm

This is a minimal change - I didn't attempt a cleanup in RecoEgamma.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31196/17839

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

RecoEgamma/EgammaPhotonAlgos
RecoMuon/L3TrackFinder
RecoMuon/TrackerSeedGenerator
RecoTracker/MeasurementDet

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @abbiendi, @echapon, @varuns23, @cericeci, @makortel, @JanFSchulte, @jhgoh, @lgray, @HuguesBrun, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @mschrode, @ebrondol, @mtosi, @dgulhan, @Fedespring, @calderona, @sobhatta, @afiqaize, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-20-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8843/console Started: 2020/08/20 19:48

[cmsbuild]

+1
Tested at: 8585095
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4682b7/8843/summary.html
CMSSW: CMSSW_11_2_X_2020-08-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4682b7/8843/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2608222
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2608199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[slava77]

+1

for #31196 8585095

• code changes are technical; they are in line with the PR description and the follow up review in change return type of geomTracker to derived class (TrackerGeometry vs TrackingGeometry) #31192
• jenkins tests pass and comparisons with the baseline show no differences

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1