Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the B-Field configuration at beginRun in SimG4Core/GeometryProducer #31203

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 21, 2020

PR description:

This simple fix allows to be able to run the G4 refitting for alignment purposes on real data preventing a segfault, when crossing run boundaries described to occur in this thread.

PR validation:

The test configuration at /afs/cern.ch/cms/CAF/CMSALCA/ALCA_TRACKERALIGN/MP/MPproduction/mp3344/jobData/job181/ the.py runs successfully (caveat for testing, the changes at: cms-trackeralign:g4Refitting_10_6_X need to be merged first).

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, but will be backported to all active releases for alignment purposes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31203/17852

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

SimG4Core/GeometryProducer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 21, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 596d670
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43a6f7/8852/summary.html
CMSSW: CMSSW_11_2_X_2020-08-20-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43a6f7/8852/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2608222
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2608193
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 22, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 22, 2020

+1

@cmsbuild cmsbuild merged commit b2a91f1 into cms-sw:master Aug 22, 2020
@mmusich mmusich deleted the G4Refitting_updateBFieldAtBeginRun_11_2_X branch August 25, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants