Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214

ahinzmann · 2020-08-24T13:45:20Z

PR description:

This introduces a change for Era run2_miniAOD_UL (#27889) in the treatment of the track-vertex association for charged particles in PUPPI. The new version is called v15.
The vertex association is adapted to deal with split vertices in high hadronic activity events (more on this here: https://indico.cern.ch/event/944339/contributions/3968152/attachments/2086414/3505127/splitverticesandhighptjets.pdf).
Charged particles associated to one of the leading two pileup vertices by the vertex fit (fromPV=0), but found within dz<0.2 of the primary vertex are treated as coming from the primary vertex.
This reduces MET tails due to particles that are wrongly associated to a PU vertex, when the PV is reconstructed as 2-3 split vertices.
The overall impact on jet response, jet efficiency, fake rate, boosted object tagging is negligible.
Thus JEC and SFs derived with PUPPI v14 are applicable to PUPPI v15.
A summary of the studies is in:
https://indico.cern.ch/event/942994/contributions/3978585/attachments/2088015/3508036/puppiv15summary-1.pdf
An additional check on softdrop mass response for high pT AK8 jets can be found here:
https://indico.cern.ch/event/942994/#7-virtual-impact-of-puppi-tune

In addition rare cases with particle eta==0 that are not treated in PuppiContainer are handled by adapting the eta range start at -0.01. A permanent fix for this is in #31174.

PR validation:

scram b run-tests
runTheMatrix.py -l limited

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #31174

cmsbuild · 2020-08-24T13:45:44Z

A new Pull Request was created by @ahinzmann for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @riga, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Adapt track-vertex association in PUPPI (v15) #31174

perrotta · 2020-08-24T13:52:10Z

backport of #31174

perrotta · 2020-08-24T13:52:35Z

please test

cmsbuild · 2020-08-24T13:52:57Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-08-24-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8881/console Started: 2020/08/24 15:53

cmsbuild · 2020-08-24T15:08:59Z

+1
Tested at: b4da171
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4b22/8881/summary.html
CMSSW: CMSSW_10_6_X_2020-08-24-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-08-24T15:09:01Z

Comparison job queued.

cmsbuild · 2020-08-24T16:58:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4b22/8881/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 390 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214614
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214279
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

slava77 · 2020-08-24T17:24:02Z

Reco comparison results: 390 differences found in the comparisons

everything is in the UL re-miniAOD workflow
all_OldVSNew_RunJetHT2018DreMINIAODULwf136p88811 | 390
as expected

slava77 · 2020-08-25T14:35:31Z

CommonTools/PileupAlgos/python/customizePuppiTune_cff.py

  from PhysicsTools.PatAlgos.tools.helpers import getPatAlgosToolsTask, addToProcessAndTask
  task = getPatAlgosToolsTask(process)
  from PhysicsTools.PatAlgos.slimming.puppiForMET_cff import makePuppiesFromMiniAOD
  makePuppiesFromMiniAOD(process,True)
  process.puppi.useExistingWeights = False
  process.puppiNoLep.useExistingWeights = False
  from PhysicsTools.PatUtils.tools.runMETCorrectionsAndUncertainties import runMetCorAndUncFromMiniAOD
-  runMetCorAndUncFromMiniAOD(process,isData=(not runOnMC),metType="Puppi",postfix="Puppi",jetFlavor="AK4PFPuppi",recoMetFromPFCs=True,pfCandColl=cms.InputTag("puppiForMET"))
+  runMetCorAndUncFromMiniAOD(process,isData=(not runOnMC),metType="Puppi",postfix="Puppi",jetFlavor="AK4PFPuppi",recoMetFromPFCs=True)


is this change intended?
it looks unrelated to the change from v14 to v15.

slava77 · 2020-08-25T15:40:22Z

CommonTools/PileupAlgos/python/Puppi_cff.py

+    algos = cms.VPSet(
+                        cms.PSet(
+                         etaMin = cms.vdouble(-0.01), # include particles with eta==0 (proper fix is in #31174)
+                         etaMax = cms.vdouble(2.5),
+                         ptMin  = cms.vdouble(0.),
+                         MinNeutralPt   = cms.vdouble(0.2),
+                         MinNeutralPtSlope   = cms.vdouble(0.015),
+                         RMSEtaSF = cms.vdouble(1.0),
+                         MedEtaSF = cms.vdouble(1.0),
+                         EtaMaxExtrap = cms.double(2.0),
+                         puppiAlgos = puppiCentral
+                        ),
+                        cms.PSet(
+                         etaMin              = cms.vdouble( 2.5,  3.0),
+                         etaMax              = cms.vdouble( 3.0, 10.0),
+                         ptMin               = cms.vdouble( 0.0,  0.0),
+                         MinNeutralPt        = cms.vdouble( 1.7,  2.0),
+                         MinNeutralPtSlope   = cms.vdouble(0.08, 0.08),
+                         RMSEtaSF            = cms.vdouble(1.20, 0.95),
+                         MedEtaSF            = cms.vdouble(0.90, 0.75),
+                         EtaMaxExtrap        = cms.double( 2.0),
+                         puppiAlgos = puppiForward
+                        )
+     )


IIUC, only etaMin needs a change

Suggested change

algos = cms.VPSet(

cms.PSet(

etaMin = cms.vdouble(-0.01), # include particles with eta==0 (proper fix is in #31174)

etaMax = cms.vdouble(2.5),

ptMin = cms.vdouble(0.),

MinNeutralPt = cms.vdouble(0.2),

MinNeutralPtSlope = cms.vdouble(0.015),

RMSEtaSF = cms.vdouble(1.0),

MedEtaSF = cms.vdouble(1.0),

EtaMaxExtrap = cms.double(2.0),

puppiAlgos = puppiCentral

),

cms.PSet(

etaMin = cms.vdouble( 2.5, 3.0),

etaMax = cms.vdouble( 3.0, 10.0),

ptMin = cms.vdouble( 0.0, 0.0),

MinNeutralPt = cms.vdouble( 1.7, 2.0),

MinNeutralPtSlope = cms.vdouble(0.08, 0.08),

RMSEtaSF = cms.vdouble(1.20, 0.95),

MedEtaSF = cms.vdouble(0.90, 0.75),

EtaMaxExtrap = cms.double( 2.0),

puppiAlgos = puppiForward

)

)

algos = { 0 : dict(etaMin = {-0.01}) } # include particles with eta==0 (proper fix is in #31174)

cmsbuild · 2020-08-25T15:48:46Z

Pull request #31214 was updated. @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

slava77 · 2020-08-25T15:57:32Z

@cmsbuild please test

cmsbuild · 2020-08-25T15:57:55Z

The tests are being triggered in jenkins.

CMSSW_10_6_X_2020-08-25-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8915/console Started: 2020/08/25 17:58

cmsbuild · 2020-08-25T17:14:38Z

+1
Tested at: ed9ffe9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4b22/8915/summary.html
CMSSW: CMSSW_10_6_X_2020-08-25-1100
SCRAM_ARCH: slc7_amd64_gcc700

cmsbuild · 2020-08-25T17:14:40Z

Comparison job queued.

cmsbuild · 2020-08-25T18:56:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4b22/8915/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 394 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 3214614
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3214278
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 140 log files, 14 edm output root files, 34 DQM output files

slava77 · 2020-08-25T19:55:21Z

+1

for #31214 ed9ffe9

the backport of Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214 is appropriate in the constraints of the no-change policy and also other developments that happened between 106X and the master (in PuppiProducer)
- changes in production setup will appear only in the UL reminiAOD workflows
jenkins tests pass and comparisons with the baseline show differences only in the wf 136.88811 (UL re-mini), which start from PUPPI variables and propagate downstream to puppi-related objects.

santocch · 2020-08-26T05:51:48Z

+1

cmsbuild · 2020-08-26T05:52:08Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-08-26T06:03:58Z

+1

adapt to puppi v15

b4da171

cmsbuild added this to the CMSSW_10_6_X milestone Aug 24, 2020

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 24, 2020

cmsbuild added the backport-ok label Aug 24, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 24, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 24, 2020

slava77 reviewed Aug 25, 2020

View reviewed changes

comments from Slava

ed9ffe9

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 25, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 25, 2020

slava77 mentioned this pull request Aug 25, 2020

features for UL re-miniAOD in 10_6_X #27889

Closed

41 tasks

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Aug 26, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 26, 2020

cmsbuild merged commit 0e12c12 into cms-sw:CMSSW_10_6_X Aug 26, 2020

ahinzmann mentioned this pull request Aug 28, 2020

Adapt track-vertex association in PUPPI (v15) #31174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214

Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214

ahinzmann commented Aug 24, 2020

cmsbuild commented Aug 24, 2020 •

edited

perrotta commented Aug 24, 2020

perrotta commented Aug 24, 2020

cmsbuild commented Aug 24, 2020 •

edited

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

slava77 commented Aug 24, 2020

slava77 Aug 25, 2020

slava77 Aug 25, 2020

cmsbuild commented Aug 25, 2020

slava77 commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 •

edited

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

slava77 commented Aug 25, 2020

santocch commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

qliphy commented Aug 26, 2020

Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214

Adapt track-vertex association in PUPPI (v15) [10_6_X] #31214

Conversation

ahinzmann commented Aug 24, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 24, 2020 • edited

perrotta commented Aug 24, 2020

perrotta commented Aug 24, 2020

cmsbuild commented Aug 24, 2020 • edited

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

slava77 commented Aug 24, 2020

slava77 Aug 25, 2020

Choose a reason for hiding this comment

slava77 Aug 25, 2020

Choose a reason for hiding this comment

cmsbuild commented Aug 25, 2020

slava77 commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 • edited

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

slava77 commented Aug 25, 2020

santocch commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

qliphy commented Aug 26, 2020

cmsbuild commented Aug 24, 2020 •

edited

cmsbuild commented Aug 24, 2020 •

edited

cmsbuild commented Aug 25, 2020 •

edited