Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused GCC11Compatibility.h #31238

Merged
merged 1 commit into from Aug 28, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

GCC11Compatibility.h has been deprecated for quite some time and no code in CMSSW is using it anymore.

This was showing up as a warning in the CXXMODULES build since it is being included in the modules declaration.

PR validation:

Did a git grep GCC11Compatibility.h and had no hits.

GCC11Compatibility.h has been deprecated for quite some time and
no code in CMSSW is using it anymore.
@Dr15Jones
Copy link
Contributor Author

FYI @davidlange6

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31238/17894

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Utilities

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2020

The tests are being triggered in jenkins.

@makortel
Copy link
Contributor

Last part of #28747 (that somehow slipped through back then)

@cmsbuild
Copy link
Contributor

+1
Tested at: 205a326
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97480f/8912/summary.html
CMSSW: CMSSW_11_2_X_2020-08-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97480f/8912/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609656
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 28, 2020

+1

@cmsbuild cmsbuild merged commit 3199564 into cms-sw:master Aug 28, 2020
@Dr15Jones Dr15Jones deleted the removeGCC11Compatibility branch August 28, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants