New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused GCC11Compatibility.h #31238
Conversation
GCC11Compatibility.h has been deprecated for quite some time and no code in CMSSW is using it anymore.
FYI @davidlange6 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31238/17894
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Utilities @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
Last part of #28747 (that somehow slipped through back then) |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
GCC11Compatibility.h has been deprecated for quite some time and no code in CMSSW is using it anymore.
This was showing up as a warning in the CXXMODULES build since it is being included in the modules declaration.
PR validation:
Did a
git grep GCC11Compatibility.h
and had no hits.