Replace vstring with VInputTag in edmtest::AddIntsProducer #31245

makortel · 2020-08-25T23:18:09Z

PR description:

Title says it all. I want to use product instance labels for AddIntsProducer input.

PR validation:

Framework unit tests pass.

cmsbuild · 2020-08-25T23:18:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-25T23:26:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31245/17903

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/test/stubs/ToyIntProducers.cc modified in PR(s): Simplify specifying consumes #31223, Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/test_emptyEndPathWithTask_cfg.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Framework/test/test_emptyPathWithTask_cfg.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
- File FWCore/Integration/test/testSubProcessUnscheduled_cfg.py modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

cmsbuild · 2020-08-25T23:26:44Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Concurrency
FWCore/Framework
FWCore/Integration
FWCore/Services
FWCore/TestProcessor

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2020-08-25T23:27:53Z

@cmsbuild, please test

cmsbuild · 2020-08-25T23:28:14Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8924/console Started: 2020/08/26 01:28

cmsbuild · 2020-08-26T00:47:06Z

-1

Tested at: 7d99f6b

CMSSW: CMSSW_11_2_X_2020-08-25-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ec61e/8924/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Aug 26 02:31:51 2020-date Wed Aug 26 02:26:18 2020 s - exit: 35584

cmsbuild · 2020-08-26T00:47:08Z

Comparison job queued.

makortel · 2020-08-26T01:00:13Z

Segfault in

#3  0x00002acab5296d89 in sig_dostack_then_abort () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/pluginFWCoreServicesPlugins.so
#4  <signal handler called>
#5  0x00002acad3217535 in TIDRing::computeCrossings(TrajectoryStateOnSurface const&, PropagationDirection) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libRecoTrackerTkDetLayers.so
#6  0x00002acad3217c5c in TIDRing::groupedCompatibleDetsV(TrajectoryStateOnSurface const&, Propagator const&, MeasurementEstimator const&, std::vector<DetGroup, std::allocator<DetGroup> >&) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libRecoTrackerTkDetLayers.so
#7  0x00002acad3216ac5 in TIDLayer::groupedCompatibleDetsV(TrajectoryStateOnSurface const&, Propagator const&, MeasurementEstimator const&, std::vector<DetGroup, std::allocator<DetGroup> >&) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libRecoTrackerTkDetLayers.so
#8  0x00002acacb30fce4 in GeometricSearchDet::compatibleDetsV(TrajectoryStateOnSurface const&, Propagator const&, MeasurementEstimator const&, std::vector<std::pair<GeomDet const*, TrajectoryStateOnSurface>, std::allocator<std::pair<GeomDet const*, TrajectoryStateOnSurface> > >&) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libTrackingToolsDetLayers.so
#9  0x00002acacb30fc7d in GeometricSearchDet::compatibleDets(TrajectoryStateOnSurface const&, Propagator const&, MeasurementEstimator const&) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libTrackingToolsDetLayers.so
#10 0x00002acadde137c1 in fastsim::TrackerSimHitProducer::interact(fastsim::Particle&, fastsim::SimplifiedGeometry const&, std::vector<std::unique_ptr<fastsim::Particle, std::default_delete<fastsim::Particle> >, std::allocator<std::unique_ptr<fastsim::Particle, std::default_delete<fastsim::Particle> > > >&, RandomEngineAndDistribution const&) () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/pluginFastSimulationSimplifiedGeometryPropagatorAuto.so
#11 0x00002acadddf0eb9 in FastSimProducer::produce(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/pluginFastSimulationSimplifiedGeometryPropagatorAuto.so
#12 0x00002acaa60d12e6 in edm::stream::EDProducerAdaptorBase::doEvent(edm::EventPrincipal const&, edm::EventSetupImpl const&, edm::ActivityRegistry*, edm::ModuleCallingContext const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-08-25-1100/lib/slc7_amd64_gcc820/libFWCoreFramework.so

I don't see how this PR could have caused that.

makortel · 2020-08-26T01:02:40Z

Apparently there were random crashes in 2018 #24051

cmsbuild · 2020-08-26T02:19:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ec61e/8924/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609656
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609633
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-08-26T12:50:06Z

@cmsbuild, please test

cmsbuild · 2020-08-26T12:50:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-25-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8935/console Started: 2020/08/26 14:51

cmsbuild · 2020-08-26T14:11:44Z

+1
Tested at: 7d99f6b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ec61e/8935/summary.html
CMSSW: CMSSW_11_2_X_2020-08-25-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-26T14:11:46Z

Comparison job queued.

cmsbuild · 2020-08-26T15:44:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ec61e/8935/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609656
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2609622
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-08-26T17:56:29Z

+1

cmsbuild · 2020-08-26T17:56:55Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-08-27T01:19:16Z

+1

Replace vstring with VInputTag in edmtest::AddIntsProducer

7d99f6b

cmsbuild added this to the CMSSW_11_2_X milestone Aug 25, 2020

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Aug 25, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2020

cmsbuild added tests-rejected and removed tests-started labels Aug 26, 2020

makortel mentioned this pull request Aug 26, 2020

random errors in fastsim addons #24051

Closed

cmsbuild added comparison-available and removed comparison-pending labels Aug 26, 2020

cmsbuild removed the comparison-available label Aug 26, 2020

cmsbuild added comparison-pending tests-pending tests-started and removed tests-rejected tests-pending labels Aug 26, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 26, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 26, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Aug 26, 2020

cmsbuild mentioned this pull request Aug 26, 2020

Simplify specifying consumes #31223

Merged

cmsbuild added orp-approved and removed orp-pending labels Aug 27, 2020

cmsbuild merged commit 3464bc1 into cms-sw:master Aug 27, 2020

makortel deleted the addIntsProducer branch August 27, 2020 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace vstring with VInputTag in edmtest::AddIntsProducer #31245

Replace vstring with VInputTag in edmtest::AddIntsProducer #31245

makortel commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

makortel commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 •

edited

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020 •

edited

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

qliphy commented Aug 27, 2020

Replace vstring with VInputTag in edmtest::AddIntsProducer #31245

Replace vstring with VInputTag in edmtest::AddIntsProducer #31245

Conversation

makortel commented Aug 25, 2020

PR description:

PR validation:

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

makortel commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 • edited

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020 • edited

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

makortel commented Aug 26, 2020

cmsbuild commented Aug 26, 2020

qliphy commented Aug 27, 2020

cmsbuild commented Aug 25, 2020 •

edited

cmsbuild commented Aug 26, 2020 •

edited