Move AlignmentPositionError to DataFormats/GeometryCommonDetAlgo

[davidlange6]

removes circular dependency as discussed in #31252

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31257/17925

• This PR adds an extra 80KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/CommonAlignment
Alignment/CommonAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/TrackerAlignment
DataFormats/GeometryCommonDetAlgo
Geometry/CommonTopologies
RecoLocalTracker/SiStripRecHitConverter
RecoMTD/TransientTrackingRecHit
RecoMuon/GlobalTrackingTools
RecoMuon/TransientTrackingRecHit
RecoTracker/FinalTrackSelectors

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @slava77, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @jpata, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @yduhm, @robervalwalsh, @echapon, @alesaggio, @tlampen, @threus, @mmusich, @dgulhan, @pakhotin, @makortel, @JanFSchulte, @jhgoh, @amagitte, @HuguesBrun, @cericeci, @pieterdavid, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @mschrode, @ebrondol, @mtosi, @fabiocos, @adewit, @trocino, @gbenelli, @Fedespring, @calderona, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tlampen]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-26-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8948/console Started: 2020/08/27 12:43

[cmsbuild]

+1
Tested at: 6b8ba04
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-514b3a/8948/summary.html
CMSSW: CMSSW_11_2_X_2020-08-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-514b3a/8948/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2609639
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• The move in object, meant to resolve a circular dependency, propagates to the reco code: include files just need to be updated with the new path
• Jenkins tests pass

[cvuosalo]

+1

[cvuosalo]

@davidlange6 Thanks for finding and fixing this problem.

[kpedro88]

+upgrade

[tlampen]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1