Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partition number in GEM trigger primitives #31268

Merged
merged 15 commits into from Sep 11, 2020
Merged

Add partition number in GEM trigger primitives #31268

merged 15 commits into from Sep 11, 2020

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Aug 27, 2020

PR description:

The new GE2/1 geometry has 16 eta partitions (each strip split in 2), instead of 8 eta partitions. To prevent a miscommunication between GE2/1 TPs and the GEM-CSC local trigger, the EMTF, or the GEM packer/unpacker, I added a member part_ in the GEMPadDigi and GEMPadDigiCluster. This was requested by EMTF folks. This way it should be relatively easy to check which geometry you are dealing with by calling nPartitions(). (Retry of #30998.) 16-partition GE2/1 pads are currently rejected in the GEM-CSC trigger and GEM validation.

This PR is to be followed with an update of the EMTF to reject 16-partition GE2/1 pads temporarily until algorithms or validation modules are updated.

See also ##31264.

PR validation:

Tested with WF 23234.0

23234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Thu Aug 27 12:06:19 2020-date Thu Aug 27 11:33:38 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@watson-ij @bsunanda @jshlee @jiafulow @eyigitba

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17945

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/GEMDigi
L1Trigger/L1TGEM

@benkrikler, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald, @rovere, @watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@dildick
Copy link
Contributor Author

dildick commented Aug 27, 2020

I noticed I forgot to include a case in the cluster producer.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17947

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31268 was updated. @benkrikler, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17957

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

Pull request #31268 was updated. @benkrikler, @kmaeshima, @andrius-k, @mdhildreth, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-937961/9126/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Sep 8, 2020

Hi, can this pull request be integrated? Thanks.

@silviodonato
Copy link
Contributor

@kpedro88 do you have further comments after 58f5ad0 ?

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 8, 2020

+upgrade

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 8, 2020

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 9, 2020

+1

@dildick
Copy link
Contributor Author

dildick commented Sep 9, 2020

@civanch Can you sign off, please? Thanks!

@civanch
Copy link
Contributor

civanch commented Sep 9, 2020

+1

@kpedro88
Copy link
Contributor

@silviodonato,@qliphy please merge, @cms-sw/l1-l2 never signs

@qliphy
Copy link
Contributor

qliphy commented Sep 11, 2020

+1

@qliphy
Copy link
Contributor

qliphy commented Sep 11, 2020

merge

@cmsbuild cmsbuild merged commit 2586bd2 into cms-sw:master Sep 11, 2020
@dildick dildick deleted the from-CMSSW_11_2_X_2020-08-25-2300-add-partition-gem-tp branch September 11, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants