New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partition number in GEM trigger primitives #31268
Add partition number in GEM trigger primitives #31268
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17945
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/GEMDigi @benkrikler, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I noticed I forgot to include a case in the cluster producer. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17947
|
Pull request #31268 was updated. @benkrikler, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth can you please check and sign again. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31268/17957
|
Pull request #31268 was updated. @benkrikler, @kmaeshima, @andrius-k, @mdhildreth, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch, @kpedro88 can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi, can this pull request be integrated? Thanks. |
+upgrade |
+1 |
+1 |
@civanch Can you sign off, please? Thanks! |
+1 |
@silviodonato,@qliphy please merge, @cms-sw/l1-l2 never signs |
+1 |
merge |
PR description:
The new GE2/1 geometry has 16 eta partitions (each strip split in 2), instead of 8 eta partitions. To prevent a miscommunication between GE2/1 TPs and the GEM-CSC local trigger, the EMTF, or the GEM packer/unpacker, I added a member
part_
in theGEMPadDigi
andGEMPadDigiCluster
. This was requested by EMTF folks. This way it should be relatively easy to check which geometry you are dealing with by callingnPartitions()
. (Retry of #30998.) 16-partition GE2/1 pads are currently rejected in the GEM-CSC trigger and GEM validation.This PR is to be followed with an update of the EMTF to reject 16-partition GE2/1 pads temporarily until algorithms or validation modules are updated.
See also ##31264.
PR validation:
Tested with WF 23234.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
@watson-ij @bsunanda @jshlee @jiafulow @eyigitba