delete old headers from CommonTools/Utils.

[davidlange6]

Finishing a migration from 12 years ago...

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31274/17964

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CommonTools/Utils

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8976/console Started: 2020/08/28 10:13

[perrotta]

(Wrong comment: removed)

[davidlange6]

No, instead that includes CommonTools/UtilAlgos/interface/DeltaR.h On Aug 28, 2020, at 10:29 AM, perrotta <notifications@github.com<mailto:notifications@github.com>> wrote: CommonTools/Utils/interface/deltaR.h is still included from * Calibration/HcalAlCaRecoProducers/plugins/ConeDefinition.h * * * * — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31274 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ4AX5FGBIPGXHYXMRDSC5TGHANCNFSM4QN3FGQA>.

[perrotta]

Yes, indeed I realized it while I was writing the list and I had already amended my comment above (which got submitted by mistake) David Lange <notifications@github.com> ha scritto:

…

No, instead that includes CommonTools/UtilAlgos/interface/DeltaR.h On Aug 28, 2020, at 10:29 AM, perrotta ***@***.******@***.***>> wrote: CommonTools/Utils/interface/deltaR.h is still included from * Calibration/HcalAlCaRecoProducers/plugins/ConeDefinition.h * * * * — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31274 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ4AX5FGBIPGXHYXMRDSC5TGHANCNFSM4QN3FGQA>. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #31274 (comment)

[cmsbuild]

+1
Tested at: fc36d49
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89512b/8976/summary.html
CMSSW: CMSSW_11_2_X_2020-08-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89512b/8976/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609638
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Removed headers are not included anywhere in CMSSW
• Jenkins tests pass

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1