Fix for a bug affecting CaloMode=0,1 #313

giamman · 2013-08-14T08:45:59Z

Add the SimHit->RecHit converter of the tracker in the LocalReco sequence for CaloMode=0,1. No change for the default mode (CaloMode=3).

…ence for CaloMode=0,1

ktf · 2013-08-14T08:56:31Z

@nclopezo can you please test? Thanks.

ktf · 2013-08-14T08:56:42Z

@giamman do not forget to sign it.

cmsbuild · 2013-08-14T09:02:18Z

The following categories have been signed by agiamman (a.k.a. @giamman on GitHub): Fast Simulation

@cms-git-simulation, @cms-git-fastsim

giamman · 2013-08-14T13:44:58Z

Hi David,
I cannot access the log, if I click on that link I get:

<<
Authorization Failed

Based on the information provided to this application about you, you are not authorized to access the resource at "https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/104/consoleFull"

Please contact the administrator of this service or application if you believe this to be an error at somebody@cern.chmailto:somebody@cern.ch

But anyway, how can I have a compilation error related to FWCore/PluginManager, if I only changed a python file in a completely different directory?
Note that I tested on the IB of last night. Where did you test it?

Thanks,
Andrea

Andrea Giammanco
Phone (CERN): +41 22 76 71567
Mobiles: +41 76 2323672 (CH), +32 497 135121 (BE), +39 349 5552471 (IT)

From: David Mendez [notifications@github.com]
Sent: 14 August 2013 15:20
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] Fix for a bug affecting CaloMode=0,1 (#313)

Hi,

I am getting the following error when I try to build:

In file included from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/Fireworks/Core/interface/FWItemAccessorRegistry.h:28:0,
from /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/Fireworks/Core/src/FWItemAccessorFactory.cc:23:
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/FWCore/PluginManager/interface/PluginFactory.h:58:10: error: initializing argument 2 of 'R* edmplugin::PluginFactory::create(const string&, Args&& ...) const [with R = FWItemAccessorBase; Args = {const TClass*}; std::string = std::basic_string]'

You can see the complete logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/104/consoleFull

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/313#issuecomment-22634632.

nclopezo · 2013-08-14T13:52:00Z

Hi Andrea,

I deleted that comment, but It seems that github already had sent the
notification email. I realized that it was caused by another error that was
fixed in #314. Now I also added this pull request in my environment as
well. And I started the tests again, they are currently running.

On Wed, Aug 14, 2013 at 3:44 PM, Andrea Giammanco
notifications@github.comwrote:

Hi David,
I cannot access the log, if I click on that link I get:

<<
Authorization Failed

Based on the information provided to this application about you, you are
not authorized to access the resource at "
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/104/consoleFull"

Please contact the administrator of this service or application if you
believe this to be an error at somebody@cern.chmailto:somebody@cern.ch

But anyway, how can I have a compilation error related to
FWCore/PluginManager, if I only changed a python file in a completely
different directory?
Note that I tested on the IB of last night. Where did you test it?

Thanks,
Andrea

Andrea Giammanco
Phone (CERN): +41 22 76 71567
Mobiles: +41 76 2323672 (CH), +32 497 135121 (BE), +39 349 5552471 (IT)

From: David Mendez [notifications@github.com]
Sent: 14 August 2013 15:20
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] Fix for a bug affecting CaloMode=0,1 (#313)

Hi,

I am getting the following error when I try to build:

In file included from
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/Fireworks/Core/interface/FWItemAccessorRegistry.h:28:0,

from
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/Fireworks/Core/src/FWItemAccessorFactory.cc:23:

/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_7_0_X_2013-08-13-1400/src/FWCore/PluginManager/interface/PluginFactory.h:58:10:
error: initializing argument 2 of 'R*
edmplugin::PluginFactory::create(const string&, Args&& ...) const [with R =
FWItemAccessorBase; Args = {const TClass*}; std::string =
std::basic_string]'

You can see the complete logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/104/consoleFull

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/313#issuecomment-22634632>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/313#issuecomment-22636195
.

nclopezo · 2013-08-15T08:18:46Z

Hi Andrea,

I took the changes on top of CMSSW_7_0_X_2013-08-13-1400. And I got several unit tests failures due to segmentation violation:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test TestPoolInput had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopKinFitter had ERRORS

You can see the logs in:

/afs/cern.ch/user/d/dmendezl/Public/unitTests313.log

giamman · 2013-08-15T08:32:20Z

Hi David, that's surprising, because:

the change didn't affect the default, but two optional modes which are switched off.
those unit tests are related to the Analysis level: the first concerns PAT (= Physics Analysis Toolkit), the last three concern the TQAF (= Top Quark Analysis Toolkit), the second maybe is in the domain of Core.

Are these tests performed by taking FastSim as input? Where are they defined?

Thanks,
Andrea

Andrea Giammanco
Phone (CERN): +41 22 76 71567
Mobiles: +41 76 2323672 (CH), +32 497 135121 (BE), +39 349 5552471 (IT)

From: David Mendez [notifications@github.com]
Sent: 15 August 2013 10:18
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] Fix for a bug affecting CaloMode=0,1 (#313)

Hi Andrea,

I took the changes on top of CMSSW_7_0_X_2013-08-13-1400. And I got several unit tests failures due to segmentation violation:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test TestPoolInput had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS
---> test runtestTqafTopKinFitter had ERRORS

You can see the logs in:

/afs/cern.ch/user/d/dmendezl/Public/unitTests313.log

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/313#issuecomment-22690561.

nclopezo · 2013-08-15T09:22:14Z

Hi Andrea,

Sorry, I was trying to test your changes with the IB of 14-0200 and 14-1200, which had errors. I tried to avoid the errors by also including the pull request that reverted the change that caused one of the problems. I was checking what I did, and finally I ended running all again with CMSSW_7_0_X_2013-08-14-1400.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/115/consoleFull

All the unit tests passed.

giamman · 2013-08-15T09:28:58Z

Hi David, thanks for the update.
By the way, I am not authorized to open that page... It looks like one needs special permissions.

Cheers,
Andrea

Andrea Giammanco
Phone (CERN): +41 22 76 71567
Mobiles: +41 76 2323672 (CH), +32 497 135121 (BE), +39 349 5552471 (IT)

From: David Mendez [notifications@github.com]
Sent: 15 August 2013 11:22
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] Fix for a bug affecting CaloMode=0,1 (#313)

Hi Andrea,

Sorry, I was trying to test your changes with the IB of 14-0200 and 14-1200, which had errors. I tried to avoid the errors by also including the pull request that reverted the change that caused one of the problems. I was checking what I did, and finally I ended running all again with CMSSW_7_0_X_2013-08-14-1400.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/115/consoleFull

All the unit tests passed.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/313#issuecomment-22693043.

nclopezo · 2013-08-15T09:34:31Z

I think @ktf can help you with that.

ktf · 2013-08-15T09:55:17Z

Did you use your zh account?

giamman · 2013-08-15T10:16:20Z

Thanks, it was that! My primary CERN account is 'agiamman' (originally attached to ALEPH, not to CMS), therefore to access most CERN services, including webmail, I must log with that one.
Somehow, the CMS wikis and other CMS-only services recognize my agiamman account, therefore I tend to forget that some others do not. Is there a way to have all private CMS pages recognize it as well?

ktf · 2013-08-15T10:19:02Z

I'll ask miguel to add an exception.

Fix for a bug affecting CaloMode=0,1

Add yaml-cpp.

Gen vboson fix2

Gem status digi

* new HLT prescale interface * remove junk * enabled for MC too Co-authored-by: Matthew Nguyen <matthew.nguyen@cern.ch>

readme.md updates: AVX2, CMSSW testing (gcc and task pinning)

add the SimHit->RecHit converter of the tracker in the LocalReco sequ…

53b748e

…ence for CaloMode=0,1

ghost assigned nclopezo Aug 14, 2013

ktf added a commit that referenced this pull request Aug 15, 2013

Merge pull request #313 from giamman/fixCaloMode0and1

c89d379

Fix for a bug affecting CaloMode=0,1

ktf merged commit c89d379 into cms-sw:CMSSW_7_0_X Aug 15, 2013

ktf added a commit that referenced this pull request Jan 21, 2014

Merge pull request #313 from degano/IB/CMSSW_7_0_X/stable

5736486

Add yaml-cpp.

cvernier pushed a commit to cvernier/cmssw that referenced this pull request Feb 1, 2016

Merge pull request cms-sw#313 from jstupak/genVbosonFix2

1eb40c6

Gen vboson fix2

andjuo pushed a commit to andjuo/cmssw that referenced this pull request Feb 17, 2018

Merge pull request cms-sw#313 from hyunyong/GEMStatusDigi

1c766bf

Gem status digi

stahlleiton pushed a commit to stahlleiton/cmssw that referenced this pull request Aug 28, 2021

new HLT prescale interface (cms-sw#313)

ee055a2

* new HLT prescale interface * remove junk * enabled for MC too Co-authored-by: Matthew Nguyen <matthew.nguyen@cern.ch>

slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021

Merge pull request cms-sw#313 from trackreco/slava77-avx2

3a7e3bf

readme.md updates: AVX2, CMSSW testing (gcc and task pinning)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for a bug affecting CaloMode=0,1 #313

Fix for a bug affecting CaloMode=0,1 #313

giamman commented Aug 14, 2013

ktf commented Aug 14, 2013

ktf commented Aug 14, 2013

cmsbuild commented Aug 14, 2013

giamman commented Aug 14, 2013

nclopezo commented Aug 14, 2013

nclopezo commented Aug 15, 2013

giamman commented Aug 15, 2013

nclopezo commented Aug 15, 2013

giamman commented Aug 15, 2013

nclopezo commented Aug 15, 2013

ktf commented Aug 15, 2013

giamman commented Aug 15, 2013

ktf commented Aug 15, 2013

Fix for a bug affecting CaloMode=0,1 #313

Fix for a bug affecting CaloMode=0,1 #313

Conversation

giamman commented Aug 14, 2013

ktf commented Aug 14, 2013

ktf commented Aug 14, 2013

cmsbuild commented Aug 14, 2013

giamman commented Aug 14, 2013

nclopezo commented Aug 14, 2013

nclopezo commented Aug 15, 2013

giamman commented Aug 15, 2013

nclopezo commented Aug 15, 2013

giamman commented Aug 15, 2013

nclopezo commented Aug 15, 2013

ktf commented Aug 15, 2013

giamman commented Aug 15, 2013

ktf commented Aug 15, 2013