Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw the cluster position in Fireworks #31325

Merged
merged 1 commit into from Sep 2, 2020

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Sep 2, 2020

PR description:

This PR will draw the position of the LayerClusters in HGCAL using an arrow as a marker. It replicates what was already implemented for the seed position. This addition could be useful to visually compare the two quantities.

PR validation:

Validated using a private, local, build of Fireworks/cmsShow

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31325/18086

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

Fireworks/Calo

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Sep 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+1
Tested at: 6e230b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecbf30/9075/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6b98ba2 into cms-sw:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants