Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed include of CommandLineParser.h from HcalLutAnalyzer #31373

Merged
merged 1 commit into from Sep 8, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The class was not being used. Removing it avoids a dependency on PhysicsTools/FWLite.

PR validation:

The code compiles.

The class was not being used. Removing it avoids a dependency on
PhysicsTools/FWLite.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31373/18192

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CaloOnlineTools/HcalOnlineDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

+1
Tested at: 1a38d33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77aac3/9156/summary.html
CMSSW: CMSSW_11_2_X_2020-09-06-0000
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77aac3/9156/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77aac3/9156/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77aac3/9156/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Sep 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 8, 2020

+1

@cmsbuild cmsbuild merged commit 2ce72b2 into cms-sw:master Sep 8, 2020
@Dr15Jones Dr15Jones deleted the fixHcalLutAnalyzer branch September 9, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants