Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid computing unnneded quantities in HLTPixlMBForAlignmentFilter #31387

Merged
merged 1 commit into from Sep 9, 2020

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Sep 8, 2020

PR description:

The static analyzer point out a few variables which are unnededly computed and never used in HLTPixlMBForAlignmentFilter
They are removed here

PR validation:

It compiles
No changes expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31387/18226

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

A new Pull Request was created by @perrotta for master.

It involves the following packages:

HLTrigger/special

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Sep 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

+1
Tested at: b59aadc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4dfc/9184/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd4dfc/9184/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 06d7c18 into cms-sw:master Sep 9, 2020
@perrotta perrotta deleted the removeUnneededZvtxfitValues branch September 9, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants