drop type specs in RecoParticleFlow #31389

jeongeun · 2020-09-08T15:08:57Z

PR description:

Update the safer syntax for existing parameter :

drop type specifications where the original parameter exists.
move all parameter inside the clone

Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
(The references were PR#30700, PR#30827, PR#30947,PR#31162,PR#31243,PR#31332)

In this PR, total 19 files updated.

RecoParticleFlow/{Configuration} 2 files
RecoParticleFlow/{PFClusterProducer} 10 files
RecoParticleFlow/{PFProducer} 5 files
RecoParticleFlow/{PFTracking} 2 files

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

cmsbuild · 2020-09-08T15:09:24Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-08T15:16:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31389/18234

This PR adds an extra 28KB to repository

cmsbuild · 2020-09-08T15:16:58Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoParticleFlow/Configuration
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @makortel, @felicepantaleo, @riga, @cbernet, @rovere, @lgray, @clelange, @lecriste, @hatakeyamak, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-09-08T15:19:58Z

please test

cmsbuild · 2020-09-08T15:20:22Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9194/console Started: 2020/09/08 17:22

cmsbuild · 2020-09-08T16:49:12Z

+1
Tested at: 786ae10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbfff/9194/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-08T16:49:14Z

Comparison job queued.

cmsbuild · 2020-09-08T18:15:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbfff/9194/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-09-09T09:47:43Z

RecoParticleFlow/PFProducer/python/particleFlowEGamma_cff.py

+    pfCandidates          = "particleFlowTmp",
+    valueMapPhoPFblockIso = "gedPhotonsTmp",
+    valueMapElePFblockIso = "gedGsfElectronsTmp"
+)
 #change particleBasedIsolation object to tmp
 IsoConeDefinitionsPhotonsTmp = copy.deepcopy(IsoConeDefinitions)
 for iPSet in IsoConeDefinitionsPhotonsTmp:
  iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedPhotonsTmp")


Suggested change

iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedPhotonsTmp")

iPSet.particleBasedIsolation = "particleBasedIsolationTmp:gedPhotonsTmp"

perrotta · 2020-09-09T09:48:26Z

RecoParticleFlow/PFProducer/python/particleFlowEGamma_cff.py

+    srcToIsolate        = "gedGsfElectronsTmp",
+    srcForIsolationCone = "pfNoPileUpCandidates"
+)
+
 for iPSet in egmElectronIsolationCITK.isolationConeDefinitions:
  iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedGsfElectronsTmp")


Suggested change

iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedGsfElectronsTmp")

iPSet.particleBasedIsolation = "particleBasedIsolationTmp:gedGsfElectronsTmp"

perrotta · 2020-09-09T09:48:52Z

RecoParticleFlow/PFProducer/python/particleFlowEGamma_cff.py

+    srcToIsolate        = "gedGsfElectronsTmp",
+    srcForIsolationCone = "pfPileUpAllChargedParticles"
+)
+
 for iPSet in egmElectronIsolationPileUpCITK.isolationConeDefinitions:
  iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedGsfElectronsTmp")


Suggested change

iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedGsfElectronsTmp")

iPSet.particleBasedIsolation = "particleBasedIsolationTmp:gedGsfElectronsTmp"

cmsbuild · 2020-09-09T11:49:27Z

Pull request #31389 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2020-09-09T12:01:50Z

please test

cmsbuild · 2020-09-09T12:02:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9222/console Started: 2020/09/09 14:02

cmsbuild · 2020-09-09T13:34:34Z

+1
Tested at: c792051
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbfff/9222/summary.html
CMSSW: CMSSW_11_2_X_2020-09-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-09T13:34:37Z

Comparison job queued.

cmsbuild · 2020-09-09T15:06:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbfff/9222/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-09-09T15:38:22Z

+1

Dropped type specification for parameters in cloned configs, as planned
Jenkins tests pass

cmsbuild · 2020-09-09T15:38:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-09-09T19:41:30Z

+1

drop type specs where original parameter exist

786ae10

cmsbuild added this to the CMSSW_11_2_X milestone Sep 8, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 8, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 8, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 8, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 8, 2020

perrotta reviewed Sep 9, 2020

View reviewed changes

fix

c792051

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Sep 9, 2020

cmsbuild added the code-checks-approved label Sep 9, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 9, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Sep 9, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 9, 2020

cmsbuild merged commit e1fce0f into cms-sw:master Sep 9, 2020

This was referenced Sep 21, 2020

drop type specs in RecoMET #31523

Merged

drop type specs in RecoBTag #31538

Merged

This was referenced Oct 11, 2020

drop type specs in RecoTauTag #31748

Merged

drop type specs in RecoVertex RecoPixelVertexing #31784

Merged

jeongeun mentioned this pull request Oct 21, 2020

drop type specs in RecoHGCal #31881

Merged

jeongeun mentioned this pull request Nov 5, 2020

drop type specs in RecoHI {HiEgammaAlgos,HiJetAlgos,HiMuonAlgos} #32031

Merged

jeongeun mentioned this pull request Feb 16, 2021

drop type specifications in RecoParticleFlow #32923

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop type specs in RecoParticleFlow #31389

drop type specs in RecoParticleFlow #31389

jeongeun commented Sep 8, 2020 •

edited

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

perrotta commented Sep 8, 2020

cmsbuild commented Sep 8, 2020 •

edited

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

perrotta Sep 9, 2020

perrotta Sep 9, 2020

perrotta Sep 9, 2020

cmsbuild commented Sep 9, 2020

perrotta commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 •

edited

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

perrotta commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

silviodonato commented Sep 9, 2020

	iPSet.particleBasedIsolation = cms.InputTag("particleBasedIsolationTmp", "gedPhotonsTmp")
	iPSet.particleBasedIsolation = "particleBasedIsolationTmp:gedPhotonsTmp"

drop type specs in RecoParticleFlow #31389

drop type specs in RecoParticleFlow #31389

Conversation

jeongeun commented Sep 8, 2020 • edited

PR description:

PR validation:

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

perrotta commented Sep 8, 2020

cmsbuild commented Sep 8, 2020 • edited

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

cmsbuild commented Sep 8, 2020

perrotta Sep 9, 2020

Choose a reason for hiding this comment

perrotta Sep 9, 2020

Choose a reason for hiding this comment

perrotta Sep 9, 2020

Choose a reason for hiding this comment

cmsbuild commented Sep 9, 2020

perrotta commented Sep 9, 2020

cmsbuild commented Sep 9, 2020 • edited

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

perrotta commented Sep 9, 2020

cmsbuild commented Sep 9, 2020

silviodonato commented Sep 9, 2020

jeongeun commented Sep 8, 2020 •

edited

cmsbuild commented Sep 8, 2020 •

edited

cmsbuild commented Sep 9, 2020 •

edited