remove L1Trigger/L1TMuon dependency from DataFormats/L1TMuon

[davidlange6]

new version of #31346 which stayed around long enough to get conflicts but no comments...

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31417/18285

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/CSCMuonPortCard.cc modified in PR(s): Clean-up CSC trigger configuration for Run-3 and Phase-2 #31401
  • File L1Trigger/L1TMuonEndCap/src/EMTFSubsystemCollector.cc modified in PR(s): Temporarily reject 16-partition GE2/1 clusters in the EMTF #31409

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9244/console Started: 2020/09/10 10:26

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

DataFormats/L1TMuon
EventFilter/L1TRawToDigi
L1Trigger/CSCCommonTrigger
L1Trigger/CSCTrackFinder
L1Trigger/CSCTriggerPrimitives
L1Trigger/L1TMuon
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap
Validation/MuonCSCDigis

@benkrikler, @kmaeshima, @andrius-k, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @valuev, @dildick, @thomreis, @ptcox this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 0b34499
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-032b0e/9244/summary.html
CMSSW: CMSSW_11_2_X_2020-09-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-032b0e/9244/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

+1

[Dr15Jones]

Would a enum class be better since this is presently violating the CMS naming rules for namespaces.

[davidlange6]

this namespace is used extensively already...

[davidlange6]

but of course its easy to change if we don't mind it being different from the rest of the L1TMuon code.

[silviodonato]

@cms-sw/l1-l2 do you have any comments?

[silviodonato]

merge
@cms-sw/l1-l2