Fix sorting in TTUTrackingAlg (11_1_X)

[makortel]

PR description:

Backport of #31415

This PR fixes a bug in the sorting comparison functions in TTUTrackingAlg that cause crashes reported in #31258 and #31410. The std::sort requires the comparison functor to meet the requirements of Compare (loosely needs "less than"), which the current "less or equal than" does not meet, leading to undefined behavior. This PR changes the functors to use "less than" comparison.

Furthermore, as pointed out in #31258 (comment), this PR proposes to fix a logic bug in the code that assumes std::sort() to be stable (it is not) by combining the two comparison operations into one, and replacing the function structs with lambdas.

For consistency this PR also changes the subsequent call to std::unique() to use a lambda instead of function object.

PR validation:

The crash reported in #31410 disappears, limited matrix runs.

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/RPCTechnicalTrigger

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix sorting in TTUTrackingAlg #31415

[makortel]

type bug-fix

[makortel]

backport of #31415

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-09-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9252/console Started: 2020/09/10 22:02

[cmsbuild]

+1
Tested at: ea02b13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec0e4e/9252/summary.html
CMSSW: CMSSW_11_1_X_2020-09-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec0e4e/9252/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ec0e4e/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780741
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[qliphy]

+1

[qliphy]

merge