Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ESProducers in Calib* and Cond* from setConsumes() to type-deducing consumes() #31437

Merged
merged 1 commit into from Sep 15, 2020

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 11, 2020

PR description:

Migrating setConsumes() calls to the simpler consumes introduced in #31223.

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31437/18312

  • This PR adds an extra 68KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibCalorimetry/CastorCalib
CalibCalorimetry/EcalLaserCorrection
CalibCalorimetry/HcalPlugins
CalibCalorimetry/HcalTPGEventSetup
CalibPPS/ESProducers
CalibTracker/SiPhase2TrackerESProducers
CalibTracker/SiPixelESProducers
CalibTracker/SiStripCommon
CalibTracker/SiStripESProducers
CondTools/Hcal
CondTools/L1TriggerExt

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @kpedro88, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @rchatter, @forthommel, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @argiro, @dkotlins, @mmusich, @abdoulline this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

FYI @Dr15Jones

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 79cbace
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-648119/9271/summary.html
CMSSW: CMSSW_11_2_X_2020-09-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-648119/9271/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620305
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2620276
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@pohsun
Copy link

pohsun commented Sep 14, 2020

+1

@kpedro88
Copy link
Contributor

+upgrade

@rekovic
Copy link
Contributor

rekovic commented Sep 15, 2020

+1

@ggovi
Copy link
Contributor

ggovi commented Sep 15, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 15, 2020

+1

@cmsbuild cmsbuild merged commit 59afced into cms-sw:master Sep 15, 2020
@makortel makortel deleted the consumesCalibCond branch September 15, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants