[DD4hep] Start Core Code Cleanup

[ianna]

PR description:

• Remove unused clases
• Clean up unused API
• Tidy up header guards

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31454/18349

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): CTPPS Sim and Reco: Change of paradigm: oldDD and DD4hep in parallel #31383

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/EcalAlgo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-14-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9320/console Started: 2020/09/14 14:00

[cmsbuild]

-1

Tested at: 6fcde3c

CMSSW: CMSSW_11_2_X_2020-09-14-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-394c2d/9320/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation error when building:

>> Building binary testDD4hepDDSolidShapes
Copying tmp/slc7_amd64_gcc820/src/DetectorDescription/DDCMS/test/testDD4hepDDSolidShapes/testDD4hepDDSolidShapes to productstore area:
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/src/DetectorDescription/DDCMS/test/DDExpandedView.cppunit.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/src/DetectorDescription/DDCMS/test/testRunner.cpp
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/src/DetectorDescription/DDCMS/test/DDExpandedView.cppunit.cc:4:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/poison/DetectorDescription/DDCMS/interface/DDExpandedView.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/src/DetectorDescription/DDCMS/test/DDExpandedView.cppunit.cc: In member function 'void testDDExpandedView::checkExpandedView()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-09-14-1100/src/DetectorDescription/DDCMS/test/DDExpandedView.cppunit.cc:41:3: error: 'DDExpandedView' was not declared in this scope
   DDExpandedView epview(cpview);


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31454/18370

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/interface/DDFilteredView.h modified in PR(s): CTPPS Sim and Reco: Change of paradigm: oldDD and DD4hep in parallel #31383

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9340/console Started: 2020/09/15 15:16

[cmsbuild]

Pull request #31454 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[cmsbuild]

+1
Tested at: 66e770f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-394c2d/9340/summary.html
CMSSW: CMSSW_11_2_X_2020-09-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-394c2d/9340/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2620306
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2620277
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[cvuosalo]

unhold

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1