Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LogDebug to CandViewExtractor #31455

Merged
merged 2 commits into from Sep 14, 2020
Merged

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Sep 14, 2020

PR description:

Adds some LogDebug messages to check isolation calculations. Needed for debugging PR #31298.

PR validation:

compiles, runs and produces output for 136.7611.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31455/18351

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31455/18353

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

PhysicsTools/IsolationAlgos

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor Author

jpata commented Sep 14, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2020

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Sep 14, 2020

should we add this to the reco category?

@cmsbuild
Copy link
Contributor

+1
Tested at: f7bf2fe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d19d/9324/summary.html
CMSSW: CMSSW_11_2_X_2020-09-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08d19d/9324/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2620306
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2620278
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

should we add this to the reco category?

I agree, see cms-sw/cms-bot#1381

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit feeae3f into cms-sw:master Sep 14, 2020
@jpata jpata deleted the log_CandViewExtractor branch October 6, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants