Clean BuildFiles in DataFormats #31459
Conversation
guitargeek
changed the title
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31459/18360
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: DataFormats/CSCDigi @SiewYan, @gouskos, @kpedro88, @Martin-Grunewald, @alberto-sanchez, @santocch, @peruzzim, @perrotta, @civanch, @makortel, @cmsbuild, @agrohsje, @fwyzard, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @mdhildreth, @slava77, @jpata, @mkirsano, @fgolf, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+upgrade |
|
+1 |
|
+1
|
|
+xpog |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
| @@ -1,7 +1,5 @@ | |||
| <use name="DataFormats/CaloRecHit"/> | |||
| <use name="DataFormats/Common"/> | |||
| <use name="DataFormats/EgammaCandidates "/> | |||
There was a problem hiding this comment.
hi @guitargeek - I don't understand this change. DataFormats/EgammaCandidates is used in 3 headers (all of which are then needed to build srcs in this package.
There was a problem hiding this comment.
Hello! My script is grepping for the exact dependency name, which was here "DataFormats/EgammaCandidates " with a whitespace in the end. By eye this whitespace is not so easy to see when scrolling through the diffs, so I was not prepared for this problem.
I'll make sure to strip the witespaces before grepping next time!
There was a problem hiding this comment.
ah..I also missed the whitespace.. that explains it:) Thanks.
| @@ -2,7 +2,7 @@ | |||
| <use name="DataFormats/Math"/> | |||
| <use name="FWCore/ParameterSet"/> | |||
| <use name="FWCore/Reflection"/> | |||
| <use name="FWCore/SOA"/> | |||
| <use name="FWCore/SOA" source_only="1"/> | |||
There was a problem hiding this comment.
@smuzaffar I get the following complaint from scram in CMSSW_11_2_X_2020-09-18-1100
****WARNING: Invalid tool FWCore/SOA. Please fix src/CommonTools/Utils/BuildFile.xml file.
Are we missing something more?
There was a problem hiding this comment.
Do you get this in latest IB?
There was a problem hiding this comment.
No, in CMSSW_11_2_X_2020-09-22-1100 there is no such complaint. Thanks!
PR description:
Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #31445).
As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.
PR validation:
CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with
git grep.