HcalDQM - Separating HO and HB in depth plots (11_1_X backport)

[lwang046]

Backport of PR #31473. This update is supposed to be used in next MWGRs.

[cmsbuild]

A new Pull Request was created by @lwang046 for CMSSW_11_1_X.

It involves the following packages:

DQM/HcalCommon

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@abdoulline, @DryRun this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-09-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9372/console Started: 2020/09/16 11:02

[cmsbuild]

+1
Tested at: a19dd60
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeefd0/9372/summary.html
CMSSW: CMSSW_11_1_X_2020-09-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeefd0/9372/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-eeefd0/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780668
• DQMHistoTests: Total failures: 212
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780406
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 7714.842 KiB( 35 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 0.006 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.004 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.002 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 1000.0,... ): 0.001 KiB Hcal/RawTask
• DQMHistoSizes: changed ( 10024.0,... ): 223.951 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 10024.0,... ): 149.309 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 10024.0,... ): 49.804 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 136.731,... ): 24.896 KiB Hcal/RawTask
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

@lwang046 since this PR is to be used in the upcoming MWGR, @andrius-k tested it in Online DQM playback with run 337235 and it seems to work fine, however hcalcalib client is NOT processing any events despite Calibration stream files are there
My understanding is that this PR affects both hcalcalib and hcalreco Online Clients, but it would be nice if you could confirm or comment before proceeding

[lwang046]

Hi @jfernan2, from the code this PR will inflict those same changes to hcalcalib and hcalreco, since there are hcal tasks in those clients that have depth plots. Is the hcalcalib not processed due to the changes in this PR? I can't see how this could cause that immediately.

[jfernan2]

Is the hcalcalib not processed due to the changes in this PR?

No we don't think that either, we are just wondering if the calib does not process events due to the run number used or something else....

[lwang046]

hcalcalib client is NOT processing any events despite Calibration stream files are there

I'm not familiar with the calibration stream files, the hcalcalib client indeed runs on separate events from the normal DQM streams and handles raw data with input tag "hltHcalCalibrationRaw". It is a collection of hcal diagnostic tasks.

From the DQM online GUI it seems this run 337235 indeed has no event filled by the hcalcalib client: https://cmsweb.cern.ch/dqm/online/start?runnr=337235;dataset=/Global/Online/ALL;sampletype=online_data;filter=all;referencepos=overlay;referenceshow=customise;referencenorm=True;referenceobj1=refobj;referenceobj2=none;referenceobj3=none;referenceobj4=none;search=;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=HCALcalib;size=M;root=HcalCalib/Layouts;focus=;zoom=no;

[jfernan2]

Thanks @lwang046
We switched to another run and all went fine

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1