Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue 31502: problem with FakeHLT in PU 2017-2018 relvals #31503

Merged
merged 3 commits into from Sep 21, 2020

Conversation

jfernan2
Copy link
Contributor

PR description:

Upon creation of PR #31472 202X upgrade samples were wrongly assigned FakeHLT Menu configurations for DQM/Validation steps.

This step fixes the issue as reported on #31502

PR validation:

Validated with
runTheMatrix.py --list=11834.99,12634.99,13034.99

if this PR is a backport please specify the original PR and why you need to backport that PR:

No

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Sep 18, 2020
@jfernan2
Copy link
Contributor Author

solves #31502

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor Author

please test workflow 11834.99,12634.99,13034.99

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31503/18454

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 6436a9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947c70/9420/summary.html
CMSSW: CMSSW_11_2_X_2020-09-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947c70/9420/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-947c70/12634.99_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-947c70/13034.99_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2540471
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2540448
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

Co-authored-by: Kevin Pedro <kpedro88@gmail.com>
@cmsbuild
Copy link
Contributor

+1
Tested at: 7a58830
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947c70/9428/summary.html
CMSSW: CMSSW_11_2_X_2020-09-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-947c70/9428/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-947c70/12634.99_TTbar_14TeV+2023PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-947c70/13034.99_TTbar_14TeV+2024PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSim+PREMIX_PremixPU+DigiPU+RecoPU+HARVESTPU+Nano

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2540471
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2540448
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Sep 19, 2020

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Sep 21, 2020

hello @chayanit, @wajidalikhan, @kpedro88, @jordan-martins
can you please sign and integrate this PR at earliest convenience? It's stopping some developments for lack of a working premixed workflow for testing.

@boudoul
Copy link
Contributor

boudoul commented Sep 21, 2020

a more explicit title would be appreciated, thank you .

@jfernan2 jfernan2 changed the title Fix to issue 31502 Fix to issue 31502: problem with FakeHLT in PU 2017-2018 relvals Sep 21, 2020
@silviodonato
Copy link
Contributor

urgent

@chayanit
Copy link

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 21, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants