[HGCAL] Material budget code not working after CMSSW_11_2_0_pre2

[apsallid]

PR description:

After CMSSW_11_2_0_pre2 the usual workflow for the HGCAL material budget analysis stopped working with error [1]. The solution seems to be related with PR #28619 , which did the job for the Tracker and now also corrects error [1].

PR validation:

We tested the whole workflow locally in multiple ibs and prereleases. Details on the workflow can be found in [2]. We will soon correct the recipe to use python and not cmsRun executable in the
relevant runP_HGCal_cfg.py line, among other updates to webpage [2].

This is not a backport.

[1]

An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:single_neutrino_random.root could not be opened.
      [b] Fatal Root Error: @sub=TClass::LoadClassInfo
no interpreter information for class TFile is available even though it has a TClass initialization routine.

[2] http://hgcal.web.cern.ch/hgcal/MaterialBudget/MaterialBudget/

@rovere @felicepantaleo @vargasa @ebrondol

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31504/18459

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Validation/Geometry

@andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @lecriste, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-17-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9425/console Started: 2020/09/18 12:53

[vargasa]

Hi @apsallid, just a suggestion: maybe you can also include the execution of this script in the unit test Validation/Geometry/test/genTrackerPlots.sh so problems can be flagged earlier and automatically

[cmsbuild]

+1
Tested at: f625fe4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94772e/9425/summary.html
CMSSW: CMSSW_11_2_X_2020-09-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94772e/9425/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2540471
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2540448
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[jfernan2]

+1

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[rovere]

Hi @apsallid, just a suggestion: maybe you can also include the execution of this script in the unit test Validation/Geometry/test/genTrackerPlots.sh so problems can be flagged earlier and automatically

I'm not sure if @apsallid followed this excellent suggestion by adding the test directly in this PR. If that's not the case, as it seems to me, I'd recommend following the advice. Thanks, @vargasa for pointing this out.

[apsallid]

Is there time? I mean it is fully signed. Could i add it now?

[qliphy]

@apsallid You can make a new PR to add the test.