[HGC trigger] Update module mapping

[jbsauvan]

PR description:

Update module mapping with additional wafers appearing after fix in the definition of valid cells. Fix issue #31506.

Depends on external cms-data/L1Trigger-L1THGCal#20

PR validation:

Tested workflow 23234.0
Removes warning messages.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31524/18491

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

test parameters
pull_requests = cms-data/L1Trigger-L1THGCal#20

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1THGCal#20

• CMSSW_11_2_X_2020-09-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9462/console Started: 2020/09/21 16:35

[cmsbuild]

+1
Tested at: 2df7a32
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f226d/9462/summary.html
CMSSW: CMSSW_11_2_X_2020-09-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f226d/9462/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2540471
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2540442
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[kpedro88]

+upgrade

[rekovic]

@jbsauvan Thanks. Should we have a backport to CMSSW_11_1_X?

As I understand, this PR is not meant to introduce any changes on the active HGC cells, and therefore is not supposed to have any effect on Level1 Phase2 Trigger ParticleFlow and Egamma in the EndCap. Strictly speaking, we should have a backport of this PR into 11_1, in which case it would be included it in the finally validated release for reprocessing of HLT TDR samples. (Attn @kpedro88 @silviodonato @Sam-Harper @fwyzard )

Attn: @gpetruc @cerminar

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[jbsauvan]

@rekovic, there is no effect on the active trigger cells.
It will only fix the warnings that appeared after a fix in the HGCAL geometry (#31428). And in any case, it doesn't seem that this PR has been backported.

[silviodonato]

+1

[rekovic]

@jbsauvan Mind you that this PR is depending on a newly introduced external library in 11_2. Fine with me if other stake-holders are OK to go without backport. If no backport is made, one less thing to change underneath in 11_1.

[rekovic]

As I said, I don't expect any effects on L1T, but to be safe with 11_2 this will have to be validated in the future, ideally future Phase2 L1T RelVal and Phase2 HLT RelVal).

[kpedro88]

as @jbsauvan indicated, this PR is needed for compatibility with an HGCal geometry bug fix that has not been backported to 11_1_X. (It was deemed too late to include this in HLT TDR production, since most of the production is already finished, and the physics changes are minimal.) Therefore, this PR should not be backported either.