Ensure HGCAL RecHit map is filled also without RECO #31536
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31536/18524
|
|
A new Pull Request was created by @lecriste (Leonardo Cristella) for master. It involves the following packages: Fireworks/Calo @makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
|
The tests are being triggered in jenkins.
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
@silviodonato Do I need to make a new PR for 'master' branch for the change to be included in future upgrade releases? |
|
+1 |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
This PR is already for |
|
@silviodonato I see now and I also see that it will be added to CMSSW_2_0_X releases. Thanks! |
|
+1 |
PR description:
This PR ensures the HGCAL RecHit map is available in Fireworks, since the Producer introduced by #30061 may not be run (e.g. without RECO). No changes are expected in the output, it restores the correct cmsShow functionality for the 3D RecHit view.
PR validation:
The following Exception thrown by cmsShow is fixed:
The data is registered in the file but is not available for this event.