Fix failure in L1Trigger/TrackFindingTracklet reported in ASAN

[mrodozov]

PR description:

Fixes at least one unit test in ASAN IB
SLHCUpgradeSimulations/Geometry -> testPhase2PixelNtuple
Using what #30913 suggests

PR validation:

the unit test runs

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31555/18572

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/TrackFindingTracklet/src/FitTrack.cc modified in PR(s): Added a flag for enabling the application of the TED and TRE tables. #30847, fix identified ASAN problem #31554

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

Duplicate of #31554 ?
In any case the PR title is misleading as the package involved is actually L1Trigger/TrackFindingTracklet and the unit test just happens to consume it.

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9526/console Started: 2020/09/23 20:28

[cmsbuild]

-1

Tested at: efd2a19

CMSSW: CMSSW_11_2_X_2020-09-23-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdd106/9526/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

The relvals timed out after 4 hours.

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31555/18597

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/TrackFindingTracklet/src/FitTrack.cc modified in PR(s): Added a flag for enabling the application of the TED and TRE tables. #30847, fix identified ASAN problem #31554

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9545/console Started: 2020/09/24 14:49

[cmsbuild]

Pull request #31555 was updated. @cmsbuild, @rekovic, @benkrikler can you please check and sign again.

[cmsbuild]

+1
Tested at: fec21a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdd106/9545/summary.html
CMSSW: CMSSW_11_2_X_2020-09-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bdd106/9545/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2539438
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2539415
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[smuzaffar]

@rekovic, @benkrikler can you please review this?
@qliphy , @silviodonato this fixes most of ASAN IBs relvals failures. This change here does not change the ebhaviour of code. It just makes sure that we check for the size before accessing the memory.

[rekovic]

+1

[rekovic]

Attn @skinnari @tomalin

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1