Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Remove Shape Wrapper Classes #31581

Merged
merged 1 commit into from Oct 6, 2020

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 25, 2020

PR description:

The wrapper classes are replaced with an enhanced DD4hep API available from a recent version.

Please, do not test until the following PRs are merged:
#31578
#31571
#31577

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@ianna
Copy link
Contributor Author

ianna commented Sep 25, 2020

hold

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31581/18631

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @ianna
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

This PR is low-priority. It is a desirable code re-organization, but it is not essential for correct functionality, since the current code also works.

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

unhold

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

please test with #31649

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #31649

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

-1

Tested at: f275921

CMSSW: CMSSW_11_2_X_2020-10-02-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05f749/9708/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

--- Registered EDM Plugin: GeometryVeryForwardGeometryBuilderPlugins
Entering library rule at Geometry/VeryForwardGeometryBuilder
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/CTPPSGeometry.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/poison/DetectorDescription/DDCMS/interface/DDShapes.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^~~~~
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDescBuilder.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/module.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc:17:


@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

please test with #31652, #31649

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #31652,#31649

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+1
Tested at: f275921
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-816e09/9711/summary.html
CMSSW: CMSSW_11_2_X_2020-10-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-816e09/9711/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants