New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Remove Shape Wrapper Classes #31581
Conversation
hold |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31581/18631
|
Pull request has been put on hold by @ianna |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
This PR is low-priority. It is a desirable code re-organization, but it is not essential for correct functionality, since the current code also works. |
unhold |
please test with #31649 |
The tests are being triggered in jenkins.
|
-1 Tested at: f275921 CMSSW: CMSSW_11_2_X_2020-10-02-1100 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: --- Registered EDM Plugin: GeometryVeryForwardGeometryBuilderPlugins Entering library rule at Geometry/VeryForwardGeometryBuilder >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/CTPPSGeometry.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc:17: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/poison/DetectorDescription/DDCMS/interface/DDShapes.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^~~~~ >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDescBuilder.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/module.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-02-1100/src/Geometry/VeryForwardGeometryBuilder/src/DetGeomDesc.cc:17: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The wrapper classes are replaced with an enhanced DD4hep API available from a recent version.
Please, do not test until the following PRs are merged:
#31578
#31571
#31577
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: