Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dqmEnvSiPixelQuality from DQMEventInfo to DQMHarvestingMetadata #31609

Merged
merged 1 commit into from Oct 5, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 29, 2020

PR description:

Allows to display on GUI metadata information for the SiPixel Bad Components PCL workflow.
This piece was leftover from the migration at #28821.

PR validation:

Produced a test file using wf 1040.0 and injected to private local GUI:

without this PR:

image

with this PR:

image

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31609/18669

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiPixelQuality

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@ferencek, @mmusich, @dkotlins, @tocheng, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2020

test parameters:
workflows = 1001.2, 1040

@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 54e7f51
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-259160/9640/summary.html
CMSSW: CMSSW_11_2_X_2020-09-28-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-259160/9640/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-259160/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-259160/1040.0_RunZeroBias2017F+RunZeroBias2017F+TIER0RAWSIPIXELCAL+ALCASPLITSIPIXELCAL+ALCAHARVDSIPIXELCAL

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2539438
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2539415
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor

assign dqm

since the change is purely a change of DQM tools. The alca signature will follow immediately after the DQM sign-off.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

New categories assigned: dqm

@jfernan2,@andrius-k,@fioriNTU,@kmaeshima,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 4, 2020

+1

@christopheralanwest
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9e912a1 into cms-sw:master Oct 5, 2020
@mmusich mmusich deleted the migrateToDQMHarvestingMetadata branch October 7, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants