Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Remove Spurious Include #31652

Merged
merged 1 commit into from Oct 6, 2020

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 2, 2020

PR description:

  • DDShapes classes and corresponding utilities have been deprecated

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #31581,#31649

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31652/18751

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/VeryForwardGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+1
Tested at: 3139d73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-816e09/9711/summary.html
CMSSW: CMSSW_11_2_X_2020-10-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-816e09/9711/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Oct 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants