New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx263 Try to resolve the orientation index issue for HGCal V13/V14 #31653
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31653/18752
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31653/18753
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/ForwardCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins.
|
Pull request #31653 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@bsunanda I just noticed some problems reported by the static checks:
|
@kpedro88 Can you approve this PR now - I need it for something else. I am sending a separate PR for the static checks |
+upgrade |
@cvuosalo @silviodonato Can you approve this PR and merge it at the earliest? |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Try to resolve the orientation index issue for HGCal V13/V14
PR validation:
Tested using runTheMatrix workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special