Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx263 Try to resolve the orientation index issue for HGCal V13/V14 #31653

Merged
merged 6 commits into from Oct 12, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 2, 2020

PR description:

Try to resolve the orientation index issue for HGCal V13/V14

PR validation:

Tested using runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31653/18752

  • This PR adds an extra 40KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 2, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31653/18753

  • This PR adds an extra 40KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/ForwardCommonData
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

+1
Tested at: 45a162b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b10f74/9712/summary.html
CMSSW: CMSSW_11_2_X_2020-10-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b10f74/9712/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Pull request #31653 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

+1
Tested at: 11e0f59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b10f74/9820/summary.html
CMSSW: CMSSW_11_2_X_2020-10-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b10f74/9820/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542194
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

@bsunanda I just noticed some problems reported by the static checks:

/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalHEFileAlgo.cc:503:70: error: use of undeclared identifier 'wafers_'
          edm::LogVerbatim("HGCalGeom") << " DDHGCalHEFileAlgo: " << wafers_[type] << " number " << copy << " type "
                                                                     ^
1 error generated.
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-08-1100/src/Geometry/HGCalCommonData/src/HGCalGeomParameters.cc:1965:7: warning: Value stored to 'n' is never read
      n = 0;
      ^   ~
1 warning generated.

@bsunanda
Copy link
Contributor Author

@kpedro88 Can you approve this PR now - I need it for something else. I am sending a separate PR for the static checks

@kpedro88
Copy link
Contributor

+upgrade

@bsunanda
Copy link
Contributor Author

@cvuosalo @silviodonato Can you approve this PR and merge it at the earliest?

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2b03e03 into cms-sw:master Oct 12, 2020
@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants