Partially fix CLCT position bias after CCLUT (CCLUT-8)

[dildick]

PR description:

In recent studies, a bias was found in the 1/2-strip, 1/4-strip and 1/8-strip positions of about 0.17. The bias has now been eliminated for the 1/2 position. A bias of < 0.1 strip remains for the 1/4 and 1/8 strip positions (this may be due to how we define the 1/n-strip position: center or middle). New LUTs provided here: cms-data/L1Trigger-CSCTriggerPrimitives#3.

PR validation:

Tested with /RelValSingleMuPt10/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW and /RelValSingleMuFlatPt2To100/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW

Most recent presentation summarizing the results https://indico.cern.ch/event/965106/contributions/4062917/attachments/2122267/3572271/CSCResolutionNewPatterns_SD_20201014.pdf

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tahuang1991 Please pick-up the new .mem files from https://github.com/cms-data/L1Trigger-CSCTriggerPrimitives.

[cmsbuild]

The code-checks are being triggered in jenkins.

[dildick]

A few validation plots (not for publication):

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31656/18757

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631
  • File L1Trigger/CSCTriggerPrimitives/test/macros/CCLUTLinearFitWriter.cpp modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[dildick]

The CCLUT algorithm is not enabled yet, so there shouldn't be changes in any of the workflows.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31656/18761

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631
  • File L1Trigger/CSCTriggerPrimitives/test/macros/CCLUTLinearFitWriter.cpp modified in PR(s): Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631

[dildick]

I had a closer look at the CLCT bending resolution. Preliminary plots (not for publication) are attached.

It seems that for the position LUT the ceil. For the bending LUT floor seems more appropriate...

Anyway it would be good to check the bending resolutions for highly displaced muons and see if it looks similar.

[cmsbuild]

Pull request #31656 was updated. @benkrikler, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch can you please check and sign again.

[dildick]

For non-ME1/1 there is an bending bias of about -0.1, which I have yet to sort out.

[dildick]

Look-up tables in cms-data/L1Trigger-CSCTriggerPrimitives#3 were updated with the correct slope definition.

[silviodonato]

urgent

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6326

• CMSSW_11_2_X_2020-10-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10145/console Started: 2020/10/20 18:39

[dildick]

@rekovic @silviodonato Thanks.

[cmsbuild]

+1
Tested at: e56e5a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02b4a3/10145/summary.html
CMSSW: CMSSW_11_2_X_2020-10-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02b4a3/10145/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2544100
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2544071
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files