Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles in DetectorDescription #31663

Merged
merged 1 commit into from Oct 6, 2020
Merged

Clean BuildFiles in DetectorDescription #31663

merged 1 commit into from Oct 6, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #31590).

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31663/18774

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2020

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DetectorDescription/DDCMS
DetectorDescription/Parser
DetectorDescription/RegressionTest
ElectroWeakAnalysis/ZEE
Geometry/HcalAlgo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Oct 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

The tests are being triggered in jenkins.

@ianna
Copy link
Contributor

ianna commented Oct 5, 2020

@guitargeek - Thanks! The changes for DD and Geometry look good to me :-)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

+1
Tested at: 5100d83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d66e9/9734/summary.html
CMSSW: CMSSW_11_2_X_2020-10-05-1200
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d66e9/9734/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Oct 5, 2020

+1

@silviodonato
Copy link
Contributor

merge

@guitargeek
Copy link
Contributor Author

The bot is asleep?

@santocch
Copy link

santocch commented Oct 8, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants