Phase2 IT RechHit DQM and Validation modules #31666

sroychow · 2020-10-05T11:34:47Z

PR description:

This PR adds the DQM and Validation modules for Phase2 IT RecHits. Along with that, a couple of utility headers are added containing common functions used by all Phase2 tracker DQM, Validation modules.

PR validation:

This PR was validated using Phase2 wfs - 23234.0, 30634.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

cmsbuild · 2020-10-05T11:35:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-05T11:39:52Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18782

This PR adds an extra 32KB to repository
Found files with invalid states:
- Validation/SiTrackerPhase2V/interface/Phase2ValidationUtil.h:
  - Added: f81d1c9
  - Deleted: 20c9432

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18782/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18782/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-10-05T11:43:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-05T11:49:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18783

This PR adds an extra 32KB to repository
Found files with invalid states:
- Validation/SiTrackerPhase2V/interface/Phase2ValidationUtil.h:
  - Added: f81d1c9
  - Deleted: 20c9432

cmsbuild · 2020-10-05T11:49:41Z

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

DQM/SiTrackerPhase2
Validation/SiTrackerPhase2V

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@arossi83, @sroychow this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2020-10-05T12:01:10Z

please test

cmsbuild · 2020-10-05T12:01:32Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-05-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9728/console Started: 2020/10/05 14:03

mmusich · 2020-10-05T12:10:47Z

@emiglior @skinnari FYI

mmusich · 2020-10-05T12:14:45Z

DQM/SiTrackerPhase2/interface/TrackerPhase2DQMUtil.h

+
+namespace Phase2TkUtil {
+
+  std::string getITHistoId(uint32_t det_id, const TrackerTopology* tTopo) {


@sroychow am I wrong or this (and the other method getOTHistoId below), can be used as a drop-in replacement here:

cmssw/Validation/SiTrackerPhase2V/plugins/Phase2TrackerValidateDigi.cc

Line 1073 in 9e912a1

std::string Phase2TrackerValidateDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) {

and here:

cmssw/DQM/SiTrackerPhase2/plugins/Phase2TrackerMonitorDigi.cc

Line 711 in 473501c

std::string Phase2TrackerMonitorDigi::getHistoId(uint32_t det_id, const TrackerTopology* tTopo, bool flag) {

?

@mmusich yes this is intended to replace all getHistoId calls in the digi module as well.

thanks. So this will be done in another separate PR?

DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc

Validation/SiTrackerPhase2V/plugins/Phase2ITValidateRecHit.cc

mmusich · 2020-10-05T12:31:54Z

DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc

+  // Get the geometry
+  edm::ESHandle<TrackerGeometry> geomHandle;
+  iSetup.get<TrackerDigiGeometryRecord>().get(geomHandle);
+  const TrackerGeometry* tkGeom = &(*geomHandle);


this could ported to use esconsumes.

DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.cc

cmsbuild · 2020-10-05T14:05:35Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-12T10:54:30Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-12T11:02:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31666/18978

This PR adds an extra 16KB to repository
Found files with invalid states:
- Validation/SiTrackerPhase2V/plugins/Phase2ITValidateRecHit.h:
  - Added: 2c556d6
  - Modified: 98177f2, 14b04a8, 182d4ed
  - Deleted: c36609d
- DQM/SiTrackerPhase2/python/Phase2ITMonitorRecHit_cfi.py:
  - Added: 98177f2
  - Deleted: 182d4ed
- DQM/SiTrackerPhase2/plugins/Phase2ITMonitorRecHit.h:
  - Added: 98177f2
  - Modified: 66cc135, 14b04a8, 182d4ed, 516628c
  - Deleted: c36609d
- Validation/SiTrackerPhase2V/python/Phase2ITValidateRecHit_cfi.py:
  - Added: 2c556d6
  - Modified: 98177f2
  - Deleted: 182d4ed
- Validation/SiTrackerPhase2V/interface/Phase2ValidationUtil.h:
  - Added: 2c556d6
  - Deleted: 98177f2

cmsbuild · 2020-10-12T11:02:50Z

Pull request #31666 was updated. @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

mmusich · 2020-10-12T12:53:05Z

please test

cmsbuild · 2020-10-12T12:53:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-11-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9889/console Started: 2020/10/12 14:56

cmsbuild · 2020-10-12T15:00:34Z

+1
Tested at: 49ac5cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d268/9889/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-12T15:00:37Z

Comparison job queued.

cmsbuild · 2020-10-12T16:26:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36d268/9889/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 295085.376 KiB( 34 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 37575.132 KiB TrackerPhase2ITRecHit/EndCap_Side2
DQMHistoSizes: changed ( 23234.0,... ): 37575.132 KiB TrackerPhase2ITRecHit/EndCap_Side1
DQMHistoSizes: changed ( 23234.0,... ): 16699.668 KiB TrackerPhase2ITRecHit/Barrel
DQMHistoSizes: changed ( 23234.0,... ): 1771.939 KiB TrackerPhase2ITRecHit/Global_Position_RZ_IT_endcap
DQMHistoSizes: changed ( 23234.0,... ): 1771.939 KiB TrackerPhase2ITRecHit/Global_Position_RZ_IT_barrel
DQMHistoSizes: changed ( 23234.0,... ): 1415.689 KiB TrackerPhase2ITRecHit/Global_Position_XY_IT_endcap
DQMHistoSizes: changed ( 23234.0,... ): 1415.689 KiB TrackerPhase2ITRecHit/Global_Position_XY_IT_barrel
DQMHistoSizes: changed ( 23234.0,... ): 55.978 KiB TrackerPhase2ITRecHitV/EndCap_Side2
DQMHistoSizes: changed ( 23234.0,... ): 55.978 KiB TrackerPhase2ITRecHitV/EndCap_Side1
DQMHistoSizes: changed ( 23234.0,... ): 24.410 KiB TrackerPhase2ITRecHitV/Barrel
DQMHistoSizes: changed ( 23234.0 ): ...
Checked 149 log files, 22 edm output root files, 35 DQM output files

jfernan2 · 2020-10-12T16:58:53Z

+1

kpedro88 · 2020-10-12T22:25:15Z

+upgrade

cmsbuild · 2020-10-12T22:25:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-13T04:54:41Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 5, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Oct 5, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 5, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2020

mmusich reviewed Oct 5, 2020

View reviewed changes

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Oct 5, 2020

cmsbuild added the tests-pending label Oct 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 12, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Oct 12, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Oct 12, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 13, 2020

cmsbuild merged commit bf0befb into cms-sw:master Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2 IT RechHit DQM and Validation modules #31666

Phase2 IT RechHit DQM and Validation modules #31666

sroychow commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

jfernan2 commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 •

edited

mmusich commented Oct 5, 2020

mmusich Oct 5, 2020 •

edited

sroychow Oct 5, 2020

mmusich Oct 5, 2020

mmusich Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

mmusich commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 •

edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

jfernan2 commented Oct 12, 2020

kpedro88 commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

qliphy commented Oct 13, 2020


		namespace Phase2TkUtil {

		std::string getITHistoId(uint32_t det_id, const TrackerTopology* tTopo) {

Phase2 IT RechHit DQM and Validation modules #31666

Phase2 IT RechHit DQM and Validation modules #31666

Conversation

sroychow commented Oct 5, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

jfernan2 commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 • edited

mmusich commented Oct 5, 2020

mmusich Oct 5, 2020 • edited

Choose a reason for hiding this comment

sroychow Oct 5, 2020

Choose a reason for hiding this comment

mmusich Oct 5, 2020

Choose a reason for hiding this comment

mmusich Oct 5, 2020

Choose a reason for hiding this comment

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

mmusich commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 • edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

jfernan2 commented Oct 12, 2020

kpedro88 commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

qliphy commented Oct 13, 2020

cmsbuild commented Oct 5, 2020 •

edited

mmusich Oct 5, 2020 •

edited

cmsbuild commented Oct 12, 2020 •

edited