fix DDFilteredView::parameters() crashing with a pseudotrapezoid

[namapane]

PR description:

Adrressing the issue discussed in #29781 (comment), so that this hack can be removed, as also discussed here.

@ianna, the problem was not solved in #31691 so I had to fix DDFilteredView. The fix is just an explicit protection for pseudotrapezoids. I guess it could have been implemented using isASubtraction() , as introduced in 31691, but this way looks safer to me.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31712/18891

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): [DD4hep] Introduce FilteredView nextChild #31711

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31712/18891/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31712/18891/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31712/18892

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): [DD4hep] Introduce FilteredView nextChild #31711

[cmsbuild]

A new Pull Request was created by @namapane (Nicola Amapane) for master.

It involves the following packages:

DetectorDescription/DDCMS
MagneticField/GeomBuilder

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9807/console Started: 2020/10/08 15:36

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-08-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9809/console Started: 2020/10/08 16:14

[cmsbuild]

+1
Tested at: 718908f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a37ffa/9809/summary.html
CMSSW: CMSSW_11_2_X_2020-10-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a37ffa/9809/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[ianna]

+1

[perrotta]

+1

• Thanks to the protection inserted in DDFilteredView.cc, the hack for pseudotraps introduced with Handle PseudoTraps in DD4hep MF geometry builder #29781 can be reverted in MagneticField/GeomBuilder/src/DD4hep_volumeHandle.cc
• Jenkins tests pass and show no difference wrt the hacked version of the code

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1