Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPS: theta*_x and theta*_y histograms in DQM #31758

Merged
merged 2 commits into from Oct 13, 2020
Merged

PPS: theta*_x and theta*_y histograms in DQM #31758

merged 2 commits into from Oct 13, 2020

Conversation

jan-kaspar
Copy link
Contributor

PR description:

This PR adds histograms of proton scattering angles (theta*_x and theta*_y) among the standard DQM plots. These histograms are essential to judge the reconstruction quality.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Oct 12, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31758/18986

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

DQM/CTPPS

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@forthommel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 21b3337
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ab7c7/9896/summary.html
CMSSW: CMSSW_11_2_X_2020-10-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ab7c7/9896/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 61.29 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 4.086 KiB CTPPS/common
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

@jan-kaspar I am afraid the GUI is having issues with the "" in the ME names, have you tried to upload it to a test GUI?
I have and it complains, could it be possible to remove the "" from the ME name?
Thanks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jan-kaspar
Copy link
Contributor Author

@jan-kaspar I am afraid the GUI is having issues with the "" in the ME names, have you tried to upload it to a test GUI? I have and it complains, could it be possible to remove the "" from the ME name?

Thanks for your check! In bec62d1 I remove both the star and the underscore.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31758/18997

  • This PR adds an extra 16KB to repository

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #31758 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: bec62d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ab7c7/9906/summary.html
CMSSW: CMSSW_11_2_X_2020-10-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ab7c7/9906/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542202
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 61.41 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 4.094 KiB CTPPS/common
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ee81ffb into cms-sw:master Oct 13, 2020
@jan-kaspar jan-kaspar deleted the pps_dqm_theta_hists branch October 14, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jan-kaspar @cmsbuild @jfernan2 @silviodonato