Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Validation: fix some more warnings (Tracking/TrackBHadron) #31785

Merged
merged 4 commits into from Oct 16, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 14, 2020

PR description:

I have been asked by central DQM to fix some more warnings, occurring in the harvesting step , related to the Tracking Validation, of the type:

%MSG-e DQMGenericClient:  DQMGenericClient:postProcessorTrack@endRun  14-Oct-2020 04:38:34 CEST End Run: 1
 DQMGenericClient::findAllSubdirectories ==> Missing folder Tracking/TrackBHadron !!!
%MSG

The Tracking/TrackBHadron validation has been added in this PR: #17591, but only to the standalone and trackingOnly modes. This means that in the generic validation the harvesting for this folder cannot occur, as the folder is not created.
I solve this issue by creating two clones: postProcessorTrackStandalone and postProcessorTrackSummaryStandalone adding the Tracking/TrackBHadron/* to the folders to harvest and using them in the new sequence: postProcessorTrackSequenceStandalone.
This sequence will be used for the standalone usage by:

cmsDriver.py step4 ... -s HARVESTING:postProcessorTrackSequenceStandalone --filetype DQM --filein file:step3_inDQM.root

The twiki page at this link will be adjusted once this PR is merged.

I profit of this PR to clean some other warnings related to missing folder in the case of fastSim (commit 0f96a9f)

PR validation:

Passes:

runTheMatrix.py -l limited -t 4 -j  8

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport, and no backport is needed.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31785/19046

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Validation/RecoTrack

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @wmtford, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 0f96a9f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82c317/9945/summary.html
CMSSW: CMSSW_11_2_X_2020-10-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

…to be used for postProcessorTrackStandalone*
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31785/19096

@cmsbuild
Copy link
Contributor

Pull request #31785 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2020

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2020

hopefully, the last commit should solve the remaining discrepancies.

@cmsbuild
Copy link
Contributor

+1
Tested at: f54df66
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82c317/9980/summary.html
CMSSW: CMSSW_11_2_X_2020-10-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82c317/9980/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543729
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants