Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HCAL channel quality for Run 3 #31845

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates the HcalChannelQuality in Run 3 GTs for several channels in HE and HO that were fixed during LS2. The impact of the changes should be negligible.

The GT diffs are as follows:

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v9/112X_mcRun3_2021_design_v10

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v9/112X_mcRun3_2021_realistic_v10

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v9/112X_mcRun3_2021cosmics_realistic_deco_v10

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v10/112X_mcRun3_2021_realistic_HI_v11

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v9/112X_mcRun3_2023_realistic_v10

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v9/112X_mcRun3_2024_realistic_v10

PR validation:

The payloads are trivial modifications of the previous payloads. I independently cross-checked the diff of the dump of the payloads. Also, a technical test was performed: runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and should not be backported.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31845/19182

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 12024.0,7.23,159.0,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: 6911b1b

CMSSW: CMSSW_11_2_X_2020-10-18-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e9bad/10063/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e9bad/10063/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0e9bad/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0e9bad/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0e9bad/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 266 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2543752
  • DQMHistoTests: Total failures: 927
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2542803
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • conditions validated locally
  • changes in comparison tests seen only in Run 3 HO and HE distributions and their dependencies, as expected
  • unit test failures are not a consequence of this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 3c355c4 into cms-sw:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants