New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daughter/Mother Logic instead of SubtractionSolid For ME #31903
Daughter/Mother Logic instead of SubtractionSolid For ME #31903
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31903/19320
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Geometry/MuonCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@civanch : is it necessary to update the 2021 Scenario (i.e by using dict2021.py and generate2021Geometry) or not? |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
The new version of |
Comparison is ready Comparison Summary:
|
+1 @cvuosalo , may be we are ready to produce a new scenario? |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR followed what I made in PR #31683 . The Subtraction Solids have been replaced by Daughter/Mother logic inside the ME.
This PR is not related to DD4hep migration but it is needed in order to create payloads for Run3 as it has been discussed with @civanch @cvuosalo.
A cross check by @ptcox has been made before submitting this PR.
This PR will close the issue created by @ianna with the PRs #31520 and #31576
PR validation:
validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
The attached picture shows, after this PR, no Muon overlaps.
validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
Muon's volumes are not present in the overlaps.out file.
validation by runTheMatrix.py -l 25202.1 :
25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Thu Oct 22 14:44:22 2020-date Thu Oct 22 14:23:11 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed
if this PR is a backport please specify the original PR and why you need to backport that PR:
nothing special