Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TrackingParticle selector (fix for #4132) #3191

Merged
merged 2 commits into from Apr 3, 2014

Conversation

mark-grimes
Copy link

This is a fix for #4132 (EDIT - I meant #3142) which adds an extra parameter. stableOnlyTP should be true for FastSim and false for FullSim, so I set it to false. I don't actually know how FastSim is configured though.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Add TrackingParticle selector (fix for #4132)

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Tests 10000, 10200, 10400, 11200, 11400 and 12000 all pass. I have more running but I'm confident they will be okay too.

cmsbuild added a commit that referenced this pull request Apr 3, 2014
Add TrackingParticle selector (fix for #4132)
@cmsbuild cmsbuild merged commit 4ef9ae3 into cms-sw:CMSSW_6_2_X_SLHC Apr 3, 2014
@mark-grimes mark-grimes deleted the fix3142 branch April 3, 2014 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants