Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the Scenario 2021 after that the Muon Subtraction Solids have been fixed #31918

Merged
merged 1 commit into from Oct 23, 2020

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Oct 23, 2020

PR description:

This PR followed what I made in PR #31903 (merged).

As requested by @cvuosalo and @civanch this PR is necessary in order to create payloads for Run3.

@bsunanda @ianna @kpedro88 : FYI

PR validation:

  1. validation by "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"
    The attached picture shows, after this PR, no Muon overlaps.

  2. validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py >& overlaps.out &"
    Muon's volumes are not present in the overlaps.out file.

  3. validation by runTheMatrix.py -l 25202.1 :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Fri Oct 23 10:18:54 2020-date Fri Oct 23 09:58:17 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

overlapsScenario2021_23 10 2020

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31918/19341

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slomeo
Copy link
Contributor Author

slomeo commented Oct 23, 2020

please @civanch @ianna @bsunanda @cvuosalo @kpedro88 perform a "please test" command

@civanch
Copy link
Contributor

civanch commented Oct 23, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2020

The tests are being triggered in jenkins.

@civanch
Copy link
Contributor

civanch commented Oct 23, 2020

@slomeo , @ianna , this PR fixing the same file as #31915. May be we should make a common PR from these two?

@cmsbuild
Copy link
Contributor

+1
Tested at: dfc6886
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39de0f/10234/summary.html
CMSSW: CMSSW_11_2_X_2020-10-22-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39de0f/10234/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544110
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544081
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@ianna
Copy link
Contributor

ianna commented Oct 23, 2020

+1

@civanch
Copy link
Contributor

civanch commented Oct 23, 2020

urgent

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d8eac3a into cms-sw:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants